Skip to content

Conversation

@shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented Sep 25, 2025

PR

1、修复user内层组件,漏掉了autoSelect 的声明 ----- 需要发包
2、修复demo的文件名错误。

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features
    • User component now supports new optional props for enhanced configurability:
      • autoSelect: Automatically select the first available option when appropriate.
      • showEmptyValue: Toggle display of an empty value state (enabled by default).
      • showTooltip: Enable tooltips to provide additional context.
    • These options are off by default (except showEmptyValue) and do not change existing behavior unless explicitly configured.

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

Added new public props to the Vue user component. In index.ts, introduced a boolean prop showEmptyValue with default true. In pc.vue, extended the props list with autoSelect, showEmptyValue, and showTooltip. No logic, methods, or control flow were changed.

Changes

Cohort / File(s) Summary
Vue user component props surface
packages/vue/src/user/src/index.ts, packages/vue/src/user/src/pc.vue
index.ts: added showEmptyValue: { type: Boolean, default: true } to userProps. pc.vue: added public props autoSelect, showEmptyValue, showTooltip to the component’s props array; existing multipleLimit unchanged aside from ordering. No runtime logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my nose at props anew,
autoSelect, a tooltip too—
showEmptyValue joins the crew,
No logic hops, just cleaner view.
In fields of Vue I nibble through,
Carrots merged, and code feels true. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly identifies the main change—restoring the missing autoSelect prop in the user component—and does not include unrelated details or noise, so it accurately summarizes the pull request’s primary fix.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shen/fix-user-demo-id

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f69f32a and a967556.

📒 Files selected for processing (2)
  • packages/vue/src/user/src/index.ts (1 hunks)
  • packages/vue/src/user/src/pc.vue (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (2)
packages/vue/src/user/src/index.ts (1)

162-165: Prop registration keeps defaults in sync

Good call adding showEmptyValue to the public prop surface here so consumers get the documented default.

packages/vue/src/user/src/pc.vue (1)

130-133: Restored missing props on the PC template

Thanks for re-exposing autoSelect, showEmptyValue, and showTooltip—this puts the runtime prop contract back in line with the renderless layer.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the bug Something isn't working label Sep 25, 2025
@zzcr zzcr merged commit ff97491 into dev Sep 30, 2025
10 of 11 checks passed
@zzcr zzcr deleted the shen/fix-user-demo-id branch September 30, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants