fix(stop-viewer): fix npe if no stop times exist for pattern

Author: landonreed

lib/components/viewers/stop-viewer.js

@@ -285,20 +285,26 @@ class PatternRow extends Component {
       timeFormat
     } = this.props
     // sort stop times by next departure
-    let sortedStopTimes = null
-    if (stopTimes) {
+    let sortedStopTimes = []
+    const hasStopTimes = stopTimes && stopTimes.length > 0
+    if (hasStopTimes) {
       sortedStopTimes = stopTimes.sort((a, b) => {
         const aTime = a.serviceDay + a.realtimeDeparture
         const bTime = b.serviceDay + b.realtimeDeparture
         return aTime - bTime
       })
       // Cap the number of times shown for any Route at 5. TODO: make configurable
       if (sortedStopTimes.length > 0) sortedStopTimes = sortedStopTimes.slice(0, 5)
-      // Do not show any patterns with no departures happening soon.
-      const timeIsOverThreshold = sortedStopTimes[0].realtimeDeparture - getHomeTime(homeTimezone) > ONE_HOUR_IN_SECONDS * 3
-      if (sortedStopTimes[0] && timeIsOverThreshold) {
-        return null
-      }
+      // Do not show any patterns with no departures happening soon or departures
+      // that have already occurred (there appear to be cases where tomorrow's
+      // times will show up when they should not).
+      const secondsUntilFirstTime = sortedStopTimes[0].realtimeDeparture - getHomeTime(homeTimezone)
+      const firstTimeIsOverThreshold = secondsUntilFirstTime > ONE_HOUR_IN_SECONDS * 3
+      const firstTimeIsInThePast = secondsUntilFirstTime < 0
+      if (firstTimeIsInThePast || firstTimeIsOverThreshold) return null
+    } else {
+      // Do not include pattern row if it has no stop times.
+      return null
     }
     const routeName = route.shortName ? route.shortName : route.longName
 
@@ -314,7 +320,7 @@ class PatternRow extends Component {
           </div>
 
           {/* next departure preview */}
-          {stopTimes && stopTimes.length > 0 && (
+          {hasStopTimes && (
             <div className='next-trip-preview'>
               {getFormattedStopTime(sortedStopTimes[0], homeTimezone, stopViewerArriving, timeFormat)}
             </div>
@@ -343,7 +349,7 @@ class PatternRow extends Component {
                 </div>
 
                 {/* list of upcoming trips */}
-                {stopTimes && (
+                {hasStopTimes && (
                   sortedStopTimes.map((stopTime, i) => {
                     return (
                       <div