Remove most unused OTP1 fields #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
approved these changes
Oct 1, 2025
Collaborator
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Everything seems to be working, even with field trip! Additional testing might flag some problems with the util methods missing, but I think we are ok to merge for now! Happy to see so much of this old code gone
daniel-heppner-ibigroup
approved these changes
Oct 22, 2025
Contributor
daniel-heppner-ibigroup
left a comment
daniel-heppner-ibigroup
left a comment
There was a problem hiding this comment.
This is great. I support piecemeal removal of these things so we don't have one huge PR that's hard to review.
daniel-heppner-ibigroup
assigned
binh-dam-ibigroup and unassigned
daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is companion for ibi-group/otp-middleware#334 but does not require it.
Most of old OTP1, unused stuff is removed (except
agency*,route*, andstop*fields that will be addressed in a subsequent PR) and some OTP2 fields that appears in mocks but aren't queried are removed too.Fields removed:
Itinerary.transitTimeItinerary.walkLimitExceededItinerary.fareLeg.pathwayLeg.rentedCarLeg.rentedVehicleLeg.hailedCarLeg.serviceDateLeg.interstopGeometryfrom/to.origfrom/to.departurefrom/to.arrivalTrip.departureStopTimeTrip.arrivalStopTimestartTransitStopIdPR Checklist: