Skip to content

fix: Implemented passing token as query params #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: Implemented passing token as query params #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
scorm-package (0.1.0)
scorm-package (0.1.1)

GEM
remote: https://rubygems.org/
Expand Down
39 changes: 15 additions & 24 deletions lib/scorm_package/packaging/generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@
module ScormPackage
module Packaging
class Generator
attr_reader :course, :scorm_token
attr_reader :course

def initialize(course, scorm_token)
def initialize(course)
@course = course
@scorm_token = scorm_token
end

def generate
Expand Down Expand Up @@ -106,33 +105,25 @@ def generate_lesson_html(lesson)
<script src="../../scormfunctions.js"></script>
<title>#{lesson.title}</title>
<style>
.loader { display: none; position: fixed; top: 50%; left: 50%; transform: translate(-50%, -50%); }
.loader { display: block; position: fixed; top: 50%; left: 50%; transform: translate(-50%, -50%); }
iframe { display: none; width: 560px; height: 315px; border: none; }
</style>
</head>
<body>
<p>Lesson: #{lesson.title}</p>
<ul>#{lesson.videos.map do |video|
"<li>Language: #{video.language}<br>" \
"<div id=\"loader-#{video.id}\" class=\"loader\">Loading...</div>" \
"<iframe id=\"custom-iframe-#{video.id}\" data-video-url=\"#{video.video_url}\"></iframe></li>"
end.join}</ul>
<ul>
#{lesson.videos.map do |video|
"<li>Language: #{video.language}<br>" \
"<div id=\"loader-#{video.id}\" class=\"loader\">Loading...</div>" \
"<iframe id=\"iframe-#{video.id}\" src=\"#{video.video_url}\" onload=\"hideLoader('#{video.id}')\"></iframe></li>"
end.join}
</ul>

<script>
const loadIframe = async (iframe) => {
const loader = document.getElementById(`loader-${iframe.id.split('-').pop()}`);
try {
loader.style.display = 'block';
const response = await fetch(iframe.dataset.videoUrl, {
headers: { 'X-Scorm-Token': '#{scorm_token}' }
});
iframe.srcdoc = await response.text();
iframe.style.display = 'block';
} catch (error) { console.error(error); }
finally { loader.style.display = 'none'; }
};
window.addEventListener('load', () =>
document.querySelectorAll('iframe[data-video-url]').forEach(loadIframe)
);
function hideLoader(videoId) {
document.getElementById('loader-' + videoId).style.display = 'none';
document.getElementById('iframe-' + videoId).style.display = 'block';
}
</script>
</body>
</html>
Expand Down
2 changes: 1 addition & 1 deletion spec/packaging/generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
double("Course", title: "Test Course", course_modules: modules)
end

subject { described_class.new(course, "123456789") }
subject { described_class.new(course) }

describe "#generate_manifest" do
it "generates a valid SCORM manifest XML" do
Expand Down
Loading