Skip to content

Conversation

@shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented Nov 21, 2025

  • add back tracing spans for pure and metered execution mirroring interpreter implementation

@github-actions

This comment has been minimized.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #2275 will not alter performance

Comparing chore/add-tracing-spans (79430bd) with main (b2e33af)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 24 untouched
⏩ 36 skipped2

Footnotes

  1. No successful run was found on main (d475dae) during the generation of this report, so b2e33af was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@shuklaayush shuklaayush marked this pull request as ready for review November 21, 2025 19:20
@github-actions

This comment has been minimized.

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test it works with openvm-prof
I think span name needs to remain the same, but perhaps you could add a label

@github-actions

This comment has been minimized.

@shuklaayush shuklaayush merged commit 6ff454e into main Nov 21, 2025
62 of 63 checks passed
@shuklaayush shuklaayush deleted the chore/add-tracing-spans branch November 21, 2025 21:23
@github-actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+4 [+1.7%]) 238 322,610 2,058,654 - - -
fibonacci (+7 [+0.7%]) 980 1,500,209 2,100,402 - - -
regex (+6 [+0.3%]) 2,360 4,137,502 17,695,216 - - -
ecrecover (-5 [-0.7%]) 697 122,859 2,265,100 - - -
pairing 1,421 1,745,742 25,468,210 - - -

Commit: 79430bd

Benchmark Workflow

jonathanpwang pushed a commit that referenced this pull request Nov 21, 2025
- add back tracing spans for pure and metered execution mirroring
interpreter implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants