fix(react-native): wrapper page alignment #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
|
TimoGlastra
approved these changes
Oct 1, 2025
Contributor
|
Do we also need to apply this to anoncreds wrapper? |
Contributor
Author
Yes, there is a PR simliar to this one: hyperledger/anoncreds-wrapper-javascript#14 |
Contributor
|
Ah I didn't have notifications on for that repo. Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And yet another issue with Android 16KB page support: it seems that we had fixed native library, but were still compiling RN wrapper shared library with older page size. With this change, I ran ELF alignment checker script with my APK and both libraries were OK.
Hopefully this is the last fix until we can have fully Android 15 compatible wrappers.