feat: add history and other tests, update string codegen #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeuisKen
force-pushed
the
feat/rust_history
branch
from
5af9d42 to
27901ef
Compare
LeuisKen
force-pushed
the
feat/rust_history
branch
from
27901ef to
6754f98
Compare
andycall
reviewed
Mar 10, 2025
| assert(i <= size); | ||
| } | ||
| d->firing_event_iterators->pop_back(); | ||
| context->RunRustFutureTasks(); |
There was a problem hiding this comment.
Move this to rust native function callback
There was a problem hiding this comment.
But then we will run the tasks after every listener function. Should we do that?
andycall
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.