Fix malformed utf8 copyright (hot patch) #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malformed utf-8 character errors for problems. This was seen in a problem that uses the contextPolynomialFactors.pl macro.
taniwallach
approved these changes
Aug 22, 2020
Member
taniwallach
left a comment
taniwallach
left a comment
There was a problem hiding this comment.
I think it makes sense to make this a hotfix, as when the old files are read in UTF-8 it can trigger hard to understand errors. Ex: https://webwork.maa.org/moodle/mod/forum/discuss.php?d=4827
Member
|
@mgage Any comments before it is merged as a hotfix? |
Member
This was referenced Aug 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already in develop. There has been several issues with this recently, and I think it may need to be re-considered as a candidate for a hot patch.