Skip to content

Conversation

@Alex-Jordan
Copy link
Contributor

With a niceTables table in hardcopy, certain situations lead to cells using multicolumn as a way to change the column type (for example making a cell left-aligned instead when the column as a whole is centered). Before this PR, that obliterates other styling that may be in play for the column, such as a background color. This brings that styling back.

You can test with:

[@ DataTable([
            [1, 2],
            [3, 4],
        ],
        rowheaders => 1,
        align => '>{\columncolor{lightgray}}lr',
) @]*

Before this commit, the mechanism that makes the row headers all be in boldface overrides the lightgray background in the first column. With this commit, the background will still be light gray.

Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see the problem with the develop brancyh, and this fixes the problem.

@Alex-Jordan
Copy link
Contributor Author

I need group wisdom if things like these should also have hotfix peers. There are already 3 PRs open right now to fix some small thing with niceTables. Should they patch main too? Or go through develop first, then open one hotfix PR with all of them? And of course there will be more. There are one or two bugs I know about that I have yet to work on.

@drgrice1
Copy link
Member

I think I will defer to you on the niceTables.pl changes. I say hotfix'em!

@Alex-Jordan Alex-Jordan mentioned this pull request Aug 18, 2023
@drgrice1
Copy link
Member

I will merge this since the hotfix of this was merged.

@drgrice1 drgrice1 merged commit b661e4f into openwebwork:develop Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants