Skip to content

Conversation

aorinevo
Copy link
Contributor

Gradebook view renders student login names vs. assignment scores. Columns are all sortable asc/desc.

Some more things to do:

  • Link the column heading name to the student progress view containing statistics for all students for the set corresponding to the column heading name.
  • Link the row label name (login name) to the student progress view containing statistics for all sets for the student with login name corresponding to the row label name.
  • Column headings for sets should be sorted, at least alphabetically. Now it just returns some random order.
  • Add a column for totals (in percent?)

Questions:

  • Should we make certain CRUD functions available on this page, like delete assignment or delete student?
    • for example highlighting a column and pressing a delete button removes the set for all users, or have an icon in the column heading that when pressed, deletes the set for all users. More precisely, for columns, we can add an icon that gives a dropdown menu of column specific functions like sorting and including some CRUD functions. For example, consider an instructor viewing the GradeBook that decides they want to delete a set. They'll click an icon next to that set and select delete from corresponding dropdown menu. This would involve less clicks than navigating to the problem set manager, and clicking the delete button.
    • Similarly for deleting students (GradeBookRows). Perhaps something like this:
      rowcrud
    • Can we extend the CollectionTableView to include a footer for say, set averages? But this is column specific, so maybe include it in the dropdown menu suggested above.

…t login name and the relevant statistics. This is the same as choosing progress type users and progress for user_id under student progress. There isn't currently a way to go back, that's a todo. It'll be more difficult to get the collumn headings into a similar type of behavior since there is already an click event defined on the column heading.
… click trigger show-user-sets in GradeBookView. Also added titles for the different tables: gradebook, user_id, set_id. The way this is implemented breaks other table renderings, but will be fixed.
@aorinevo
Copy link
Contributor Author

aorinevo commented Nov 2, 2014

Here are some screenshots to show what the gradebook looks like so far:

  • gradebook
    gradebook
  • user_id
    user_id
  • set_id
    set_id

… set, navigate to another page, and then navigate back to GradeBook. The table will not display correctly. This is due to the getDefaultState type being set to gradebook. This commit fixes this problem.
…ectionTableView to control which column headings trigger events on the parent view. Also moved some html rendering into the gradebook.tt template. There is an issue on hard reset. click a set_id or user_id then hard reset the page. The page now displays the gradebook table but with the title of either the set_id or user_id last displayed. I'm not sure how to fix this right now. Any suggestions?
@aorinevo
Copy link
Contributor Author

aorinevo commented Nov 3, 2014

@pstaabp I think this can replace StudentProgressView at this point. What do you think?

@pstaabp pstaabp closed this Dec 31, 2014
@pstaabp pstaabp reopened this Jan 1, 2015
@aorinevo
Copy link
Contributor Author

@pstaabp, has anyone looked at this yet?

@pstaabp
Copy link
Member

pstaabp commented Mar 12, 2015

Aori,

Sorry, I haven’t had much time to work on webwork in the past few months. I hope to free up some time soon and will take a look at it. Nudge me again if you haven’t heard back in a couple of weeks.

Peter

On Mar 12, 2015, at 1:03 AM, Aori Nevo notifications@github.com wrote:

@pstaabp https://github.com/pstaabp, has anyone looked at this yet?


Reply to this email directly or view it on GitHub #514 (comment).

@aorinevo
Copy link
Contributor Author

No worries, when you get a chance.

Can you also take a look at my gradebook plugin? My goal is to integrate AN_GradeBook into WeBWorK3.

@pstaabp
Copy link
Member

pstaabp commented May 19, 2015

I'm finally getting around to this. Sorry for the delay. It's fanstastic that you've been able to wade through the code to get a new tool integrated.

I had one error in the GradeBook.pm file that may have been an old perl issue. I now have it running. I was testing on a course with about 30 Problem sets and only 2 of them show up. I think because each set wasn't assigned to each user. Here's a few general thoughts:

  • This looks similar to the StudentProgress Pane currently. (I don't recall when I put that in and if you had it when you wrote this).
  • If this is to be equivalent to the ww2 version of the Scoring Tools, we need to have some way to make a grid of all users and all problem sets as well as be able to download the file. You can look at the Classlist manager which has a way to download the classlist file as an example.
  • My thoughts on a StudentProgress/GradeBook is to have flexibility is viewing and downloading grades, which this has.
  • I've made of lot of changes recently to the CollectionTableView and I just submitted that for a pull request. That may break your code.
  • On the data transfer to the server: it appears to be fetching the data at startup. My goal has been to load up the problem set and user data at startup (since nearly every tool needs one of these) and then only load other data as needed. I can't seem to find the place where you make this call though. I would recommend to make only after this tool is loaded.
  • Also on the data fetch. I would recommend a different data format. I think it will be more robust if you have a JSON object like:
    [{ user_id: XXXX, scores: [HW1: XX, HW2, XX, HW3, XX, ...]},
    {user_ID: YYYY, scores: [HW1: XX, HW2, XX, HW3, XX, ...]}
    ...
    ]

and then parse on the client side. I'll take a look at the AN_Gradebook as well to see what else can/should be included.

@pstaabp pstaabp closed this May 29, 2015
@pstaabp pstaabp reopened this May 30, 2015
@pstaabp
Copy link
Member

pstaabp commented Aug 23, 2017

It's embarrassing that we left this so long. I have pick up webwork3 a lot this summer and planned to get this pull request going. Earlier, I switched to Dancer2, since Dancer1 is no longer supported, which is one of the reasons that this won't work as is.

I have just pulled this into one of my branches (pstaabp/ww3-features/dancer2), which will be pulled into develop this fall (I hope). I've been making a few changes to get it working with the current code, but this should make it in.

I will probably soon delete this PR since it will get integrated a different way.

@mgage mgage added the WWgradebook code related to upgrading scoring function to a full gradebook label Feb 24, 2019
@drgrice1
Copy link
Member

This has been here long enough, and clearly is not going to be merged. It will still be listed in the closed pull requests for historical purposes.

@drgrice1 drgrice1 closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webwork3 WWgradebook code related to upgrading scoring function to a full gradebook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants