-
Notifications
You must be signed in to change notification settings - Fork 3.9k
xtables-addons: update to 3.30 #28167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 0 additions & 11 deletions
11
net/xtables-addons/patches/300-fix-path-Makefile.extra.patch
This file was deleted.
Oops, something went wrong.
42 changes: 42 additions & 0 deletions
42
net/xtables-addons/patches/600-xt_pknock-fox-do_div-signness-mismatch.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| From 3c5c336fc0e47fea9baa912fc8d314ae9d1fa521 Mon Sep 17 00:00:00 2001 | ||
| From: Qingfang Deng <dqfext@gmail.com> | ||
| Date: Mon, 29 Dec 2025 07:26:07 +0100 | ||
| Subject: [PATCH] xt_pknock: fix do_div() signness mismatch | ||
|
|
||
| do_div() expects an unsigned 64-bit dividend, but time64_t is signed. On | ||
| 32-bit arch, this triggers a warnning: | ||
|
|
||
| In file included from ./arch/arm/include/asm/div64.h:107, | ||
| from ./include/linux/math.h:6, | ||
| from ./include/linux/math64.h:6, | ||
| from ./include/linux/time.h:6, | ||
| from ./include/linux/stat.h:19, | ||
| from ./include/linux/module.h:13, | ||
| from ./xtables-addons-3.30/extensions/pknock/xt_pknock.c:10: | ||
| ./xtables-addons-3.30/extensions/pknock/xt_pknock.c: In function 'has_secret': | ||
| ./include/asm-generic/div64.h:222:35: warning: comparison of distinct pointer types lacks a cast [-Wcompare-distinct-pointer-types] | ||
| 222 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \ | ||
| | ^~ | ||
| ./xtables-addons-3.30/extensions/pknock/xt_pknock.c:747:17: note: in expansion of macro 'do_div' | ||
| 747 | do_div(t, 60); | ||
| | | ||
|
|
||
| Change the type of variable `t` to uint64_t to fix this. | ||
|
|
||
| Fixes: 397b282dba9a ("xt_pknock: use walltime for building hash") | ||
| Signed-off-by: Qingfang Deng <dqfext@gmail.com> | ||
| --- | ||
| extensions/pknock/xt_pknock.c | 2 +- | ||
| 1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
|
||
| --- a/extensions/pknock/xt_pknock.c | ||
| +++ b/extensions/pknock/xt_pknock.c | ||
| @@ -743,7 +743,7 @@ has_secret(const unsigned char *secret, | ||
|
|
||
| /* Time needs to be in minutes relative to epoch. */ | ||
| { | ||
| - time64_t t = ktime_get_real_seconds(); | ||
| + uint64_t t = ktime_get_real_seconds(); | ||
| do_div(t, 60); | ||
|
pprindeville marked this conversation as resolved.
|
||
| epoch_min = t; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.