Skip to content

[ROCm] Add option to disable automatic solib and rocm rpaths adding to the final library #37513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alekstheod wants to merge 3 commits into from
Closed

[ROCm] Add option to disable automatic solib and rocm rpaths adding to the final library #37513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d87f589
Disable automatic solib rpaths adding
alekstheod Feb 7, 2026
a36a5f6
Trigger CI/CD pipelinee
alekstheod Feb 10, 2026
2d35d21
Trigger CI/CD pipelinee
alekstheod Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions third_party/gpus/crosstool/hipcc_cc_toolchain_config.bzl.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,10 @@ def _impl(ctx):
provides = ["profile"],
)

# Targets can set features = ["no_solib_rpaths"] to suppress the
# automatic solib RPATH entries and rely on their own linkopts instead.
no_solib_rpaths_feature = feature(name = "no_solib_rpaths")

runtime_library_search_directories_feature = feature(
name = "runtime_library_search_directories",
flag_sets = [
Expand Down Expand Up @@ -409,7 +413,10 @@ def _impl(ctx):
),
],
with_features = [
with_feature_set(features = ["static_link_cpp_runtimes"]),
with_feature_set(
features = ["static_link_cpp_runtimes"],
not_features = ["no_solib_rpaths"],
),
],
),
flag_set(
Expand All @@ -430,7 +437,7 @@ def _impl(ctx):
],
with_features = [
with_feature_set(
not_features = ["static_link_cpp_runtimes"],
not_features = ["static_link_cpp_runtimes", "no_solib_rpaths"],
),
],
),
Expand Down Expand Up @@ -1084,6 +1091,7 @@ def _impl(ctx):
shared_flag_feature,
linkstamps_feature,
output_execpath_flags_feature,
no_solib_rpaths_feature,
runtime_library_search_directories_feature,
library_search_directories_feature,
archiver_flags_feature,
Expand Down
24 changes: 18 additions & 6 deletions third_party/gpus/rocm/BUILD.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ string_flag(
"hermetic",
"multiple",
"system",
"link_only",
],
)

Expand All @@ -30,6 +31,13 @@ config_setting(
},
)

config_setting(
name = "link_only",
flag_values = {
":rocm_path_type": "link_only",
},
)

config_setting(
name = "using_hipcc",
values = {
Expand Down Expand Up @@ -133,9 +141,10 @@ cc_library(
deps = [":rocm_config"],
)

# workaround to bring data to the same fs layout as expected in the rocm libs
# rocblas assumes that miopen db files are located in ../share/miopen/db directory
# hibplatslt assumes that tensile files are located in ../hipblaslt/library directory
# Provides -L and -Wl,-rpath flags for ROCm libraries.
# These must live in a cc_library (not a toolchain feature) because
# cc_library linkopts propagate transitively through CcInfo to the
# final linking target, whereas toolchain features do not.
cc_library(
name = "rocm_rpath",
linkopts = select({
Expand All @@ -144,6 +153,11 @@ cc_library(
"-Wl,-rpath,external/local_config_rocm/rocm/%{rocm_root}/lib/llvm/lib",
"-Lexternal/local_config_rocm/rocm/%{rocm_root}/lib",
],
":link_only": [
"-Wl,-rpath-link,external/local_config_rocm/rocm/%{rocm_root}/lib",
"-Wl,-rpath-link,external/local_config_rocm/rocm/%{rocm_root}/lib/llvm/lib",
"-Lexternal/local_config_rocm/rocm/%{rocm_root}/lib",
],
":multiple_rocm_paths": [
"-Wl,-rpath=%{rocm_lib_paths}",
"-Lexternal/local_config_rocm/rocm/%{rocm_root}/lib",
Expand Down Expand Up @@ -254,7 +268,6 @@ cc_library(
includes = [
"%{rocm_root}/include",
],
linkopts = ["-Wl,-rpath,external/local_config_rocm/rocm/%{rocm_root}/lib"],
linkstatic = 1,
visibility = ["//visibility:public"],
deps = [
Expand All @@ -270,7 +283,6 @@ cc_library(
includes = [
"%{rocm_root}/include",
],
linkopts = ["-Wl,-rpath,external/local_config_rocm/rocm/%{rocm_root}/lib"],
linkstatic = 1,
visibility = ["//visibility:public"],
deps = [
Expand Down Expand Up @@ -301,11 +313,11 @@ cc_library(
"%{rocm_root}/lib/libMIOpen*.so*",
"%{rocm_root}/share/miopen/**",
]),
linkopts = ["-lMIOpen"],
include_prefix = "rocm",
includes = [
"%{rocm_root}/include",
],
linkopts = ["-lMIOpen"],
strip_include_prefix = "%{rocm_root}",
visibility = ["//visibility:public"],
deps = [
Expand Down
Loading