Skip to content

elevator "none" check is reverses, regression from commit d1d7e2689db9e ("cstyle: Resolve C style issues") #4507

@ColinIanKing

Description

@ColinIanKing

Commit commit d1d7e26 ("cstyle: Resolve C style issues") while cleaning up style warnings broke the none elevator comparison in module/zfs/vdev_disk.c, vdev_elevator_switch():

  •   if (!strncmp(elevator, "none", 4) && (strlen(elevator) == 4))
    
  •   if (strncmp(elevator, "none", 4) && (strlen(elevator) == 4) == 0)
    

The code no longer returns 0 when elevator == "none".

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions