Stop using "zstreamdump" in tests/ #12277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstreamdump was replaced with "zstream dump"; let's stop using the old name, compat symlink or no. Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
gmelikov
approved these changes
Jun 24, 2021
ghost
linked an issue
ghost
approved these changes
Jun 24, 2021
behlendorf
approved these changes
Jun 24, 2021
behlendorf
pushed a commit
that referenced
this pull request
Jun 24, 2021
zstreamdump was replaced with "zstream dump"; let's stop using the old name, compat symlink or no. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes #12277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When hacking on a patch to an existing change, I found ZTS failing because it wanted to use the
zstreamdumpsymlink even though it wasn't creating it even if I nuked bin/.I chose to remove the need to use it, rather than figure out why it wasn't generating it properly.
Description
Removes the remaining uses of
zstreamdumpin tests/ in favor ofzstream dump(except the test "send-c_zstreamdump.ksh", as it didn't seem especially useful to rename, and could confuse people's runfiles), including in commands.cfg.How Has This Been Tested?
Full run of ZTS passed with these changes with no errors,
Types of changes
Checklist:
Signed-off-by.