Linux 4.12 compat: super_setup_bdi_name() #6089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
the
Type: Building
|
@behlendorf, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dechamps, @chrisrd and @gmelikov to be potential reviewers. |
tuxoko
suggested changes
May 1, 2017
config/kernel-bdi.m4
Outdated
| dnl # 2.6.32 - 2.6.33, bdi_setup_and_register() is not exported. | ||
| dnl # 2.6.34 - 3.19, bdi_setup_and_register() takes 3 arguments. | ||
| dnl # 4.0 - 4.10, bdi_setup_and_register() takes 2 arguments. | ||
| dnl # 4.11 - x.y, super_setup_bdi_name() new interface. |
module/zfs/zfs_vfsops.c
Outdated
| sb->s_time_gran = 1; | ||
| sb->s_blocksize = recordsize; | ||
| sb->s_blocksize_bits = ilog2(recordsize); | ||
| zfsvfs->z_bdi.ra_pages = 0; |
Contributor
There was a problem hiding this comment.
Do we need to modify sb->s_bdi->ra_pages for 4.12+?
Also, we may want to get rid of z_bdi to save space.
behlendorf
force-pushed
the
updated-bdi-compat
branch
from
d053c16 to
cb8d5e3
Compare
Contributor
Author
|
@tuxoko good points, how about this. The updated patch refactors the code such that all backing_dev_info struct management is handled in the wrapper functions. After a successful call to |
tuxoko
approved these changes
May 2, 2017
Contributor
|
One nit, the commit title should be 4.12 |
Contributor
Author
|
Indeed, I'll fix it in the merge unless I need to refresh this for other reasons. Thanks. |
All filesystems were converted to dynamically allocated BDIs. The destruction of backing_dev_info structures is handled as part of super block destruction. Refactor the code to abstract away the details of seting up and destroying an sbi. Reviewed-by: Chunwei Chen <david.chen@osnexus.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
behlendorf
force-pushed
the
updated-bdi-compat
branch
from
cb8d5e3 to
195d47b
Compare
behlendorf
changed the title
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jun 5, 2017
All filesystems were converted to dynamically allocated BDIs. The destruction of backing_dev_info structures is handled as part of super block destruction. Refactor the code to abstract away the details of creating and destroying a BDI. Reviewed-by: Chunwei Chen <david.chen@osnexus.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#6089
tonyhutter
pushed a commit
that referenced
this pull request
Jun 9, 2017
All filesystems were converted to dynamically allocated BDIs. The destruction of backing_dev_info structures is handled as part of super block destruction. Refactor the code to abstract away the details of creating and destroying a BDI. Reviewed-by: Chunwei Chen <david.chen@osnexus.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #6089
tonyhutter
added a commit
to tonyhutter/zfs
that referenced
this pull request
Jul 10, 2017
This includes code that was mistakenly left out of the 7dae2c8 merge into 0.6.5.10. Its inclusion fixes a kernel warning on Kubuntu 17.04: WARN_ON(sb->s_bdi != &noop_backing_dev_info); Reviewed-by: Chunwei Chen <david.chen@osnexus.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#6089 Closes openzfs#6324 (backported from zfs upstream commit 7dae2c8) Signed-off-by: Colin Ian King <colin.king@canonical.com>
tonyhutter
added a commit
to tonyhutter/zfs
that referenced
this pull request
Jul 10, 2017
This includes code that was mistakenly left out of the 7dae2c8 merge into 0.6.5.10. Its inclusion fixes a kernel warning on Kubuntu 17.04: WARN_ON(sb->s_bdi != &noop_backing_dev_info); Reviewed-by: Chunwei Chen <david.chen@osnexus.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#6089 Closes openzfs#6324 (backported from zfs upstream commit 7dae2c8) Signed-off-by: Colin Ian King <colin.king@canonical.com>
tonyhutter
added a commit
that referenced
this pull request
Jul 20, 2017
This includes code that was mistakenly left out of the 7dae2c8 merge into 0.6.5.10. Its inclusion fixes a kernel warning on Kubuntu 17.04: WARN_ON(sb->s_bdi != &noop_backing_dev_info); Reviewed-by: Chunwei Chen <david.chen@osnexus.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #6089 Closes #6324 (backported from zfs upstream commit 7dae2c8) Signed-off-by: Colin Ian King <colin.king@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All filesystems were converted to dynamically allocated BDIs. The
destruction of backing_dev_info structures is handled as part of
super block destruction.