Skip to content

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Nov 13, 2024

  • Upgrade Python dependencies
  • Fix small warnings in Dockerfile:
    • use AS instead of as
    • use LABEL key=value instead of LABEL key value

@benoit74 benoit74 self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (f434258) to head (d110981).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files           4        4           
  Lines         376      376           
  Branches       48       37   -11     
=======================================
  Hits          347      347           
  Misses         25       25           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74
Copy link
Contributor Author

@josephlewis42 I've updated the dependencies before the release, would be happy to have your feedback on this (tests are OK and I ran cpp succesfully)

Copy link
Collaborator

@josephlewis42 josephlewis42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also ran Vue to confirm.

Would you enable squash merging on this repo so these two commits will be squashed? That'll also help the dev loop to prevent the need for --amend and --force constantly.

@benoit74
Copy link
Contributor Author

Let's give it a try with squash and merge, no strong opinion on my side.

@benoit74 benoit74 merged commit 81aa5df into main Nov 14, 2024
8 checks passed
@benoit74 benoit74 deleted the upgrade_deps branch November 14, 2024 08:01
@benoit74 benoit74 added this to the 0.2.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants