Fixed unset mainpage in Creator #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgaudin
changed the title
Contributor
|
@rgaudin CI is failing, you know why? |
Member
Author
|
No, it's been failing since https://github.com/openzim/python-libzim/runs/753243874?check_suite_focus=true but I doub't removing this |
mgautierfr
force-pushed
the
rgaudin/fix-mainpage
branch
from
4d10f1d to
39d6ab2
Compare
Contributor
|
The CI was using a old version of libzim. New version fix a race condition when we delete the creator just after ("to soon") we call the finalize method. We last version of libzim CI is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #36 by fixing the
OverriddenZimCreator::getMainUrlsignature.