Skip to content

rename get_namespaces_count with get_namespace_count #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2020
Merged

rename get_namespaces_count with get_namespace_count #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libzim/wrapper.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ cdef class FilePy:
A string containing initials of all namespaces in the file (ex: "-AIMX") """
return self.c_file.getNamespaces().decode("UTF-8", "strict")

def get_namespaces_count(self, str ns) -> int:
def get_namespace_count(self, str ns) -> int:
""" Articles count within a namespace -> int

Returns
Expand Down
2 changes: 1 addition & 1 deletion tests/test_libzim_file_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def test_get_article_by_id(reader, article_data):

def test_namespace_count(reader):
namespaces = reader.namespaces
num_articles = sum(reader.get_namespaces_count(ns) for ns in namespaces)
num_articles = sum(reader.get_namespace_count(ns) for ns in namespaces)
assert reader.article_count == num_articles


Expand Down