Upgrade cython to latest stable #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgaudin
changed the title
Contributor
|
At that moment, there were a lot of problems related to segmentation faults. This version didn't cause those problems. That's all. You can try upgrade it. |
Cython is a fast evolving project with frequent fixes and improvements. Keeping up-to-date on stable version makes sense as a failure to build with a newer Cython would indicate a problem on our codebase.
rgaudin
force-pushed
the
rgaudin/upgrade-cython
branch
from
f9a1c31 to
c7d5368
Compare
Member
Author
|
rebased |
dylanmccall
pushed a commit
to dylanmccall/python-libzim
that referenced
this pull request
Jul 21, 2021
Cython is a fast evolving project with frequent fixes and improvements. Keeping up-to-date on stable version makes sense as a failure to build with a newer Cython would indicate a problem on our codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython is a fast evolving project with frequent fixes and improvements.
Keeping up-to-date on stable version makes sense as a failure to build
with a newer Cython would indicate a problem on our codebase.
@afreydev, what was the reason for using such an old version?
0.29.6is dated Feb 27, 2019.