Better error handling #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Catch all python exception, not only the getattr. - Use a string instead of a int as error "marker" to provide more information to the user. - Pass the full traceback in the string. This way the user can have information of where the exception was raised. `get_article_method_from_object` is removed as it was mainly calling `getattr` and handle error. As we also need to handle error for the method call, the handle in the specific function is not needed. And we don't need a function that just call another one.
As the libzim lacks a `cancel()` method to properly stop a ZIM file creation process without calling `finalize()` (which always creates the ZIM file), users need to cheat the creator to not call finalize(), even upon exit (as `Creator`'s destructor do call `finalize()`) Test instanciates a different python VM as the libzim_reader tests (manual garbage collection) leads to a segfault.
mgautierfr
force-pushed
the
better_error_handling
branch
from
e221bac to
ea307f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #55
This is a old commit I had in my repository. It seems a bit better than #55 that does the same thing.