Skip to content

Conversation

@rgaudin
Copy link
Member

@rgaudin rgaudin commented Jun 29, 2020

lib.cxx mirrors libzim's getRedirectUrl() with get_redirect_url().
That methods had incorrectly been named redirect_url.

zim::writer::Url
ZimArticleWrapper::getRedirectUrl() const
{
std::string redirectUrl = callCythonReturnString("get_redirect_url");
return zim::writer::Url(redirectUrl.substr(0, 1)[0], redirectUrl.substr(2, redirectUrl.length()));
}

`lib.cxx` mirrors libzim's `getRedirectUrl()` with `get_redirect_url()`.
That methods had incorrectly been named `redirect_url`.
@rgaudin rgaudin requested a review from mgautierfr June 29, 2020 22:31
@kelson42 kelson42 merged commit 5cff1c5 into master Jun 30, 2020
@kelson42 kelson42 deleted the rgaudin/redirect_url branch June 30, 2020 14:51
dylanmccall pushed a commit to dylanmccall/python-libzim that referenced this pull request Jul 21, 2021
`lib.cxx` mirrors libzim's `getRedirectUrl()` with `get_redirect_url()`.
That methods had incorrectly been named `redirect_url`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants