Only send config types on service list if controller version supports it. Fixes #601 #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plorenz
force-pushed
the
fix-config-types-on-svc-list
branch
from
4708010 to
5641135
Compare
plorenz
force-pushed
the
fix-config-types-on-svc-list
branch
from
5641135 to
05db6bf
Compare
dovholuknf
reviewed
Jul 30, 2024
ziti/client.go
Outdated
| params.Offset = &pageOffset | ||
| params.ConfigTypes = self.ConfigTypes | ||
|
|
||
| if self.supportsSetOfConfigTypesOnServiceList() { |
Member
There was a problem hiding this comment.
silly nit, but why are the Limit/Offset/ConfigTypes set in the loop. they never change, right? why not pull them outside the loop?
Member
Author
There was a problem hiding this comment.
offset gets changed, but the other two don't. moved those out of the loop
dovholuknf
approved these changes
Jul 30, 2024
Member
dovholuknf
left a comment
dovholuknf
left a comment
There was a problem hiding this comment.
perhaps a nit comment, but lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.