Skip to content

Conversation

@plorenz
Copy link
Member

@plorenz plorenz commented Jul 25, 2025

No description provided.

@plorenz plorenz requested a review from a team as a code owner July 25, 2025 14:53
Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to match expiry specifically, or is it sufficient to re-auth on any oidc error?

@plorenz
Copy link
Member Author

plorenz commented Jul 25, 2025

Do we need to match expiry specifically, or is it sufficient to re-auth on any oidc error?

Looking at the error types that can be returned on OIDC error, they generally seemed unrecoverable, so fallback to full auth seemed to make the most sense. I've ping Andrew about this, so I may have a follow-up PR if he disagrees.

@plorenz plorenz merged commit 758d150 into main Jul 25, 2025
8 checks passed
@plorenz plorenz deleted the oidc-refresh-after-sleep branch July 25, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants