fixes #811 credentials are lost when set #812
Conversation
andrewpmartinez
commented
Oct 1, 2025
andrewpmartinez
commented
- adds test for id config vs cred setting
- adds test for id config vs cred setting
| idCredentials := edge_apis.NewIdentityCredentialsFromConfig(cfg.ID) | ||
| idCredentials.ConfigTypes = cfg.ConfigTypes | ||
| cfg.Credentials = idCredentials | ||
| } |
There was a problem hiding this comment.
would you consider adding a warning in the else here? this might be confusing to people imo. Or return an error ?
There was a problem hiding this comment.
The original implementation required either an ID config or credentials, and then would error.
It was changed to not error so that delayed authentication could occur (i.e. through an access_token from oauth to satisfy an external jwt signer). So not having an id config or credential is not a warning or an error, it is legitimate use case.
Attempting to use an external jwt signer requiers the calling app to be able to make unauthenticated requests to the controller to list the externa jwt signers. The SDK was updated to have those kinds of function calls.
