Review fixes

Author: p01

src/resource-manager/resource_detail_view.js

@@ -118,7 +118,7 @@ cls.ResourceDetailView = function(id, name, container_class, html, default_handl
     this._tops = [];
     var _ele = container.querySelector("." + HIGHLIGHTED_LINE_CLASSNAME);
     if (_ele)
-      _ele.removeClass(HIGHLIGHTED_LINE_CLASSNAME)
+      _ele.removeClass(HIGHLIGHTED_LINE_CLASSNAME);
   }
 
   this.go_to_line = function(container, data)
@@ -129,7 +129,7 @@ cls.ResourceDetailView = function(id, name, container_class, html, default_handl
     this._root_ele = container.querySelector("." + RESOURCE_DETAIL_CONTAINER_CLASSNAME);
     if (this._root_ele)
     {
-      this.clear_line_highlight(this._root_ele)
+      this.clear_line_highlight(this._root_ele);
       this._target_line = Number(data.lines[0]);
       this._highlight_line(this._root_ele);
     }
@@ -199,7 +199,7 @@ cls.ResourceDetailView.create_ui_widgets = function()
 {
   new ToolbarConfig(
   {
-    view:"resource_detail_view",
+    view: "resource_detail_view",
     groups:
     [
       {
@@ -224,23 +224,16 @@ cls.ResourceDetailView.create_ui_widgets = function()
     text_search.searchDelayed(target.value);
   };
 
-  ActionBroker.
-    get_instance().
-    get_global_handler().
-      register_shortcut_listener
-      (
-        "resource-text-search",
-        cls.Helpers.shortcut_search_cb.bind(text_search)
-      );
+  ActionBroker.get_instance().get_global_handler().register_shortcut_listener(
+    "resource-text-search",
+    cls.Helpers.shortcut_search_cb.bind(text_search)
+  );
 
   var on_view_created = function(msg)
   {
     if (msg.id === "resource_detail_view")
     {
-      var scroll_container = msg.container.querySelector(".request-details");
-      if (!scroll_container)
-        scroll_container = msg.container.querySelector(".resource-detail-container");
-
+      var scroll_container = msg.container.querySelector(".resource-detail-container");
       if (scroll_container)
       {
         text_search.setContainer(scroll_container);
@@ -249,13 +242,13 @@ cls.ResourceDetailView.create_ui_widgets = function()
         );
       }
     }
-  }
+  };
 
   var on_view_destroyed = function(msg)
   {
     if (msg.id == "resource_detail_view")
       text_search.cleanup();
-  }
+  };
 
   window.messages.add_listener("view-created", on_view_created);
   window.messages.add_listener("view-destroyed", on_view_destroyed);

src/resource-manager/resource_display_broker.js

@@ -48,6 +48,7 @@ cls.ResourceDisplayBroker = function()
         if (rt_id)
           url = window.helpers.resolveURLS(runtimes.getURI(rt_id), url);
       }
+      id_or_url = url;
     }
 
     if (!this._show_resource(id_or_url, line) && url)

src/resource-manager/resource_service.js

@@ -36,7 +36,7 @@ cls.ResourceManagerService = function(view, network_logger)
       d.url = new URI(d.url);
     });
 
-    this._update({type: "_handle_list_documents"});
+    this._update();
   };
 
   this._list_documents = function()
@@ -88,13 +88,16 @@ cls.ResourceManagerService = function(view, network_logger)
 
     if (ctx.windowList.length)
     {
-      // get all the (non-suppressed) resources with content
+      // get all the (non-suppressed) resources with content, sorted by uid
       ctx.resourceList = (this._network_logger.get_resources() || [])
         .filter(function(v) {
           return !this._suppress_uids.hasOwnProperty(v.uid) && v.responsecode != 204;
-        }, this);
+        }, this)
+        .sort(function(a, b) {
+          return a.uid > b.uid ? 1 : a.uid == b.uid ? 0 : -1;
+        });
 
-      ctx.documentResourceHash = {};
+      ctx.document_resource_hash = {};
 
       // mapping of the WindowIDs in the debugging context
       var window_id_index = {};
@@ -116,7 +119,7 @@ cls.ResourceManagerService = function(view, network_logger)
               null_document_id = true;
 
             if (d.resourceID != null)
-              ctx.documentResourceHash[d.resourceID] = d.documentID;
+              ctx.document_resource_hash[d.resourceID] = d.documentID;
 
             // populate document_id_index
             document_id_index[d.documentID] = i;
@@ -152,7 +155,7 @@ cls.ResourceManagerService = function(view, network_logger)
             unknown_document_id = true;
 
           // check if this is the top resource of a document
-          var documentID = ctx.documentResourceHash[r.resource_id];
+          var documentID = ctx.document_resource_hash[r.resource_id];
           if (documentID != null && documentID != r.document_id)
             r.document_id = documentID;
 

src/resource-manager/resource_tree_view.js

@@ -140,7 +140,7 @@ cls.ResourceTreeView.create_ui_widgets = function()
 {
   new ToolbarConfig(
   {
-    view:"resource_tree_view",
+    view: "resource_tree_view",
     groups:
     [
       {
@@ -176,14 +176,10 @@ cls.ResourceTreeView.create_ui_widgets = function()
     text_search.searchDelayed(target.value);
   };
 
-  ActionBroker.
-    get_instance().
-    get_global_handler().
-      register_shortcut_listener
-      (
-        "resource-tree-text-search",
-        cls.Helpers.shortcut_search_cb.bind(text_search)
-      );
+  ActionBroker.get_instance().get_global_handler().register_shortcut_listener(
+    "resource-tree-text-search",
+    cls.Helpers.shortcut_search_cb.bind(text_search)
+  );
 
   var on_view_created = function(msg)
   {
@@ -199,13 +195,13 @@ cls.ResourceTreeView.create_ui_widgets = function()
         );
       }
     }
-  }
+  };
 
   var on_view_destroyed = function(msg)
   {
     if (msg.id == "resource_tree_view")
       text_search.cleanup();
-  }
+  };
 
   window.messages.add_listener("view-created", on_view_created);
   window.messages.add_listener("view-destroyed", on_view_destroyed);