Skip to content

Commit 0fe26d7

Browse files
author
Daniel Herzog
committed
More refactoring
1 parent cb1d183 commit 0fe26d7

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

src/network/network_details_templates.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -186,14 +186,13 @@ templates._request_headers = function(req, do_raw)
186186
{
187187
if (do_raw)
188188
{
189-
if (req.request_headers_raw) // todo: we explicitely mention missing request headers in parsed. this check here is a bit ugly.
189+
if (req.request_headers_raw)
190190
{
191191
if (!req.header_tokens)
192192
{
193-
var tokens = [];
193+
req.header_tokens = [];
194194
var tokenizer = new cls.HTTPHeaderTokenizer();
195-
tokenizer.tokenize(req.request_headers_raw, this._token_receiver.bind(this, tokens));
196-
req.header_tokens = tokens;
195+
tokenizer.tokenize(req.request_headers_raw, this._token_receiver.bind(this, req.header_tokens));
197196
}
198197
if (req.header_tokens.length)
199198
{
@@ -231,17 +230,17 @@ templates._request_headers = function(req, do_raw)
231230

232231
templates._response_headers = function(resp, do_raw)
233232
{
234-
if (!resp.response_headers) // todo: we explicitely mention missing request headers but not missing response headers // ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL
233+
// Missing response headers aren't mentioned explicitely
234+
if (!resp.response_headers)
235235
return [];
236236

237237
if (do_raw)
238238
{
239239
if (!resp.header_tokens)
240240
{
241-
var tokens = [];
241+
resp.header_tokens = [];
242242
var tokenizer = new cls.HTTPHeaderTokenizer();
243-
tokenizer.tokenize(resp.response_headers_raw, this._token_receiver.bind(this, tokens));
244-
resp.header_tokens = tokens;
243+
tokenizer.tokenize(resp.response_headers_raw, this._token_receiver.bind(this, resp.header_tokens));
245244
}
246245
if (resp.header_tokens.length)
247246
{

0 commit comments

Comments
 (0)