Skip to content

Commit 1375dfa

Browse files
author
p01
committed
Fix for DFL-3616 - Highlight resources with an "Error" HTTP Status
1 parent 451a5a8 commit 1375dfa

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

src/network/network_service.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1323,6 +1323,7 @@ cls.ResourceInfo = function(entry)
13231323
this.document_id = entry.document_id;
13241324
this.type = entry.type;
13251325
this.is_unloaded = entry.is_unloaded;
1326+
this.responsecode = entry.current_responsecode;
13261327

13271328
var lastResponse = entry.requests_responses && entry.requests_responses.last;
13281329
if (lastResponse && lastResponse.responsebody)

src/resource-manager/resource_style.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,10 @@
222222
text-overflow:ellipsis;
223223
color:#000;
224224
}
225+
.resource-detail-error
226+
{
227+
color:red;
228+
}
225229
a.external
226230
{
227231
cursor: pointer;

src/resource-manager/resource_templates.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -291,28 +291,32 @@ templates.resource_detail =
291291
{
292292
var info =
293293
{
294-
'human_url':resource.short_distinguisher,
294+
'humanUrl':resource.short_distinguisher,
295+
'responseCode':resource.responsecode+' '+cls.ResourceUtil.http_status_codes[resource.responsecode],
295296
'type':resource.type,
296297
'mimeType':resource.data.mimeType,
297298
'size':resource.size||resource.data.contentLength||resource.data.content.length,
298299
'characterEncoding':resource.encoding||resource.data.characterEncoding
299300
};
300301

302+
var isError = resource.responsecode && ![200,304].contains(resource.responsecode);
303+
301304
return (
302305
['div',
303306
['span',
304307
[
305308
'a',
306-
info.human_url,
309+
info.humanUrl,
307310
'href',resource.url,
308311
'target','_blank',
309312
'class','external'
310313
],
311314
'class','resource-detail-overview-url'
312315
],
313316
['span',
317+
(isError?info.responseCode+' - ':'')+
314318
info.mimeType+' treated as '+info.type +' '+[resource.data.meta],
315-
'class','resource-detail-overview-type'
319+
'class','resource-detail-overview-type'+(isError?' resource-detail-error':'')
316320
],
317321
['span',
318322
cls.ResourceUtil.bytes_to_human_readable(info.size)+(info.characterEncoding&&(' in '+info.characterEncoding)),

0 commit comments

Comments
 (0)