DFL-3572: Re-render the network-details view only when the opened resource is updated; Fixed pause & clear;

Author: Daniel Herzog

src/network/network_view.js

@@ -19,6 +19,7 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
   this._graph_tooltip_id = null;
   this._type_filters = null;
   this._last_render_speed = 0;
+  this._last_updated_entry = "";
   this.needs_instant_update = false;
   this.required_services = ["resource-manager", "document-manager"];
 
@@ -36,6 +37,7 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
         var min_render_delay = Math.max(MIN_RENDER_DELAY, this._last_render_speed * 2);
         if (timedelta < min_render_delay)
         {
+          this._last_updated_entry = "";
           this._render_timeout = window.setTimeout(this._create_delayed_bound,
                                                    min_render_delay - timedelta);
           return;
@@ -62,6 +64,7 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
       this._render_click_to_fetch_view(this._container);
     }
 
+    this._last_updated_entry = "";
     var now = Date.now();
     this._last_render_speed = now - started_rendering;
     this._rendertime = now;
@@ -165,7 +168,11 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
     if (this.selected && ctx.get_entry_from_filtered(this.selected))
     {
       if (this._overlay.is_active)
-        this._overlay.update();
+      {
+        if (!this._last_updated_entry || this._last_updated_entry == this.selected)
+          this._overlay.update();
+
+      }
       else
         this._overlay.show();
 
@@ -426,7 +433,7 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
 
   this._on_clear_log_bound = function(evt, target)
   {
-    this.network_logger.clear_request_context();
+    this.network_logger.remove_logger_request_context();
     this.needs_instant_update = true;
   }.bind(this);
 
@@ -465,12 +472,16 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
       {
         if (message.key === "pause")
         {
-          var is_paused = this.network_logger.is_paused;
-          var pause = settings.network_logger.get(message.key);
-          if (is_paused && !pause)
-            this.network_logger.unpause();
-          else if (!is_paused && pause)
-            this.network_logger.pause();
+          var ctx = this.network_logger.get_logger_context();
+          if (ctx)
+          {
+            var is_paused = ctx.is_paused;
+            var pause = settings.network_logger.get(message.key);
+            if (is_paused && !pause)
+              this.network_logger.unpause();
+            else if (!is_paused && pause)
+              this.network_logger.pause();
+          }
         }
         else if (message.key === "network-profiler-mode")
         {
@@ -590,15 +601,21 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
     }
   }.bind(this);
 
-  var eh = window.event_handlers;
-  var messages = window.messages;
-
   this._on_context_removed_bound = function(message)
   {
     if (message.context_type === cls.NetworkLogger.CONTEXT_TYPE_LOGGER)
       this.update();
   }.bind(this);
 
+  this._on_resource_update_bound = function(message)
+  {
+    if (message.id)
+    {
+      this._last_updated_entry = message.id;
+    }
+    this.update();
+  }.bind(this);
+
   this._init = function(id, name, container_class, html, default_handler)
   {
     var eh = window.event_handlers;
@@ -623,7 +640,7 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
 
     this.network_logger.addListener("context-added", this._on_context_established_bound);
     this.network_logger.addListener("context-removed", this._on_context_removed_bound);
-    this.network_logger.addListener("resource-update", this.update.bind(this));
+    this.network_logger.addListener("resource-update", this._on_resource_update_bound);
 
     ActionHandlerInterface.apply(this);
     this._handlers = {