Refactoring some property names for more clearness

Author: Daniel Herzog

src/network/network_details_templates.js

@@ -30,7 +30,7 @@ templates.network_log_details = function(entry, left_val)
 
 templates.network_log_detail = function(entry)
 {
-  var responsecode = entry.responsecode;
+  var responsecode = entry.last_responsecode;
   if (responsecode && responsecode in cls.ResourceUtil.http_status_codes)
      responsecode = responsecode + " " + cls.ResourceUtil.http_status_codes[responsecode];
 
@@ -43,15 +43,15 @@ templates.network_log_detail = function(entry)
           ],
           ["tr",
             ["th", ui_strings.S_HTTP_LABEL_METHOD + ":"],
-            ["td", entry.touched_network ? entry.method : ui_strings.S_RESOURCE_ALL_NOT_APPLICABLE],
-            "data-spec", "http#" + entry.method
+            ["td", entry.touched_network ? entry.last_method : ui_strings.S_RESOURCE_ALL_NOT_APPLICABLE],
+            "data-spec", "http#" + entry.last_method
           ],
           ["tr",
             ["th", ui_strings.M_NETWORK_REQUEST_DETAIL_STATUS + ":"],
             ["td",
               entry.touched_network && responsecode ? String(responsecode) : ui_strings.S_RESOURCE_ALL_NOT_APPLICABLE
             ],
-           "data-spec", "http#" + entry.responsecode
+           "data-spec", "http#" + entry.last_responsecode
           ]
         ],
         entry.touched_network ? [] : templates.did_not_touch_network(entry),

src/network/network_service.js

@@ -504,9 +504,8 @@ cls.NetworkLoggerEntry = function(id, resource_id, document_id, context_starttim
   this.starttime_relative = null;
   this.endtime = null;
   this.requests_responses = [];
-  this.responsecode = null;
-  this.status = null;
-  this.method = null;
+  this.last_responsecode = null;
+  this.last_method = null;
   this.is_unloaded = false;
   this.is_finished = false;
   this.events = [];
@@ -728,7 +727,7 @@ cls.NetworkLoggerEntryPrototype = function()
 
   this._update_event_request = function(event)
   {
-    this.method = event.method;
+    this.last_method = event.method;
     this._current_request = new cls.NetworkLoggerRequest(this);
     this.requests_responses.push(this._current_request);
     this._current_request._update_event_request(event);
@@ -763,11 +762,8 @@ cls.NetworkLoggerEntryPrototype = function()
 
   this._update_event_response = function(event)
   {
-    // On every response, entry.responsecode is overwritten to reflect what 
-    // the "final" responsecode for the request was.
-    // Each individual response is also stored as a NetworkLoggerResponse.
-    this.responsecode = event.responseCode;
-    this.had_error_response = /^[45]/.test(this.responsecode);
+    this.last_responsecode = event.responseCode;
+    this.error_in_last_response = /^[45]/.test(this.responsecode);
     this._current_response = new cls.NetworkLoggerResponse(this);
     this.requests_responses.push(this._current_response);
     this._current_response._update_event_response(event);

src/network/network_templates.js

@@ -173,7 +173,7 @@ templates.network_viewmode_graphs = function(ctx, entries, selected, width)
 
 templates.network_log_url_list_entry = function(selected, entry)
 {
-  var had_error_response = entry.had_error_response;
+  var error_in_last_response = entry.error_in_last_response;
   var not_requested = !entry.touched_network;
 
   return ["li",
@@ -186,7 +186,7 @@ templates.network_log_url_list_entry = function(selected, entry)
            "handler", "select-network-request",
            "data-object-id", String(entry.id),
            "class", (selected === entry.id ? "selected" : "") + 
-                    (had_error_response ? " " + ERROR_RESPONSE : "") + 
+                    (error_in_last_response ? " " + ERROR_RESPONSE : "") + 
                     (not_requested ? " " + NOT_REQUESTED : "")
          ];
 };
@@ -216,10 +216,10 @@ templates.network_log_url_tooltip = function(entry)
     context_string = ui_strings.S_HTTP_UNREFERENCED;
     context_type = UNREFERENCED;
   }
-  else if (entry.had_error_response)
+  else if (entry.error_in_last_response)
   {
-    context_string = entry.responsecode + 
-                     " (" + HTTP_STATUS_CODES[entry.responsecode] + ")";
+    context_string = entry.last_responsecode + 
+                     " (" + HTTP_STATUS_CODES[entry.last_responsecode] + ")";
     context_type = ERROR_RESPONSE;
   }
   else if (!entry.touched_network)

src/network/network_view.js

@@ -229,20 +229,20 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler)
     columns: {
       method: {
         label: ui_strings.S_HTTP_LABEL_METHOD,
-        getter: function(entry) { return entry.method || ""; }
+        getter: function(entry) { return entry.last_method || ""; }
       },
       responsecode: {
         label: ui_strings.S_HTTP_LABEL_RESPONSECODE,
         headertooltip: ui_strings.S_HTTP_TOOLTIP_RESPONSECODE,
         renderer: function(entry) {
-          return (entry.responsecode && String(entry.responsecode)) || "";
+          return (entry.last_responsecode && String(entry.last_responsecode)) || "";
         },
         title_getter: function(entry, renderer) {
-          if (cls.ResourceUtil.http_status_codes[entry.responsecode])
-            return String(cls.ResourceUtil.http_status_codes[entry.responsecode]);
+          if (cls.ResourceUtil.http_status_codes[entry.last_responsecode])
+            return String(cls.ResourceUtil.http_status_codes[entry.last_responsecode]);
           return renderer(entry);
         },
-        getter: function(entry) { return entry.responsecode || 0; }
+        getter: function(entry) { return entry.last_responsecode || 0; }
       },
       mime: {
         label: ui_strings.S_RESOURCE_ALL_TABLE_COLUMN_MIME,