Some cleanup.

Author: hzr

src/profiler/profiler_style.css

@@ -15,9 +15,9 @@
   left: 160px;
   right: 0;
   top: 22px;
-  height: 26px; /* 8 types * 3px height + 2 extra for padding */
-  border-top: 1px solid rgba(0, 0, 0, 0.055);
-  border-bottom: 1px solid rgba(0, 0, 0, 0.055);
+  height: 28px;
+  box-shadow: 0 1px inset rgba(0, 0, 0, 0.055),
+              0 -1px inset rgba(0, 0, 0, 0.055);
   overflow-x: hidden;
 }
 
@@ -26,8 +26,8 @@
   position: absolute;
   left: 160px;
   right: 0;
-  top: 22px;
-  height: 27px;
+  top: 23px;
+  height: 26px;
 }
 
 .profiler-timeline-background
@@ -179,14 +179,15 @@
 {
   min-width: 1px;
   height: 3px;
+  margin-top: 2px;
   position: absolute;
 }
 
 .profiler-event
 {
   min-width: 3px;
   height: 12px;
-  margin: 4px 0;
+  margin: 5px 0;
   box-shadow: inset 0 2px rgba(255, 255, 255, 0.09),
               inset 0 0 0 1px rgba(0, 0, 0, 0.07),
               inset 0 -1px rgba(0, 0, 0, 0.05);

src/profiler/profiler_templates.js

@@ -85,13 +85,14 @@ var ProfilerTemplates = function()
   var profiler_event_decl = style_sheets.getDeclaration(".profiler-event");
   var profiler_event_small_decl = style_sheets.getDeclaration(".profiler-event-small");
   var profiler_timeline_row_decl = style_sheets.getDeclaration(".profiler-timeline-row");
-  var EVENT_MIN_WIDTH = profiler_event_decl ? parseInt(profiler_event_decl.minWidth) : 0;
-  var EVENT_SMALL_MIN_WIDTH = profiler_event_decl ? parseInt(profiler_event_small_decl.minWidth) : 0;
-  var BAR_HEIGHT = profiler_timeline_row_decl
-                 ? (parseInt(style_sheets.getDeclaration(".profiler-timeline-row").height) +
-                    parseInt(style_sheets.getDeclaration(".profiler-timeline-row").paddingTop) +
-                    parseInt(style_sheets.getDeclaration(".profiler-timeline-row").paddingBottom))
-                 : 0;
+  var EVENT_MIN_WIDTH = profiler_event_decl ? parseInt(profiler_event_decl.minWidth) : 1;
+  var EVENT_SMALL_MIN_WIDTH = profiler_event_decl ? parseInt(profiler_event_small_decl.minWidth) : 1;
+  var EVENT_HEIGHT = profiler_timeline_row_decl
+                   ? (parseInt(style_sheets.getDeclaration(".profiler-timeline-row").height) +
+                      parseInt(style_sheets.getDeclaration(".profiler-timeline-row").paddingTop) +
+                      parseInt(style_sheets.getDeclaration(".profiler-timeline-row").paddingBottom))
+                   : 1;
+  var EVENT_SMALL_HEIGHT = profiler_event_decl ? parseInt(profiler_event_small_decl.height) : 1;
 
   var MIN_DURATION = ProfilerView.MIN_DURATION;
 
@@ -227,8 +228,8 @@ var ProfilerTemplates = function()
        "style",
          "width: " + width + "px; " +
          "left: " + left + "px; " +
-         "top: " + (column * 3 + 1) + "px;", // TODO: 3 -> constant
-       "class", "profiler-event-small event-type-" + event.type + "-selftime" // FIXME: not actually selftime
+         "top: " + (column * EVENT_SMALL_HEIGHT) + "px;",
+       "class", "profiler-event-small event-type-" + event.type + "-selftime" // not actually selftime, just using that color
       ]
     );
   };
@@ -249,7 +250,7 @@ var ProfilerTemplates = function()
        "style",
          "width: " + width + "px; " +
          "left: " + left + "px; " +
-         "top: " + (column * BAR_HEIGHT + 1) + "px; " +
+         "top: " + (column * EVENT_HEIGHT) + "px; " +
          (width > 46340 ? ("background-size: " + Math.floor(46340 / width * 100) + "%; ") : "") + // workaround for CORE-48579
          (HAS_UNPREFIXED_GRADIENTS
            ? "background-image: linear-gradient(0deg, transparent 0, rgba(255, 255, 255, .25) 100%), " +

src/profiler/profiler_view.js

@@ -34,7 +34,7 @@ var ProfilerView = function(id, name, container_class, html, default_handler)
   var profiler_timeline_decl = document.styleSheets.getDeclaration(".profiler-timeline");
   var profiler_event_decl = document.styleSheets.getDeclaration(".profiler-event");
   var AGGREGATED_EVENTS_WIDTH = profiler_timeline_decl ? parseInt(profiler_timeline_decl.left) : 0;
-  var BAR_MIN_WIDTH = profiler_event_decl ? parseInt(profiler_event_decl.minWidth) : 0;
+  var EVENT_MIN_WIDTH = profiler_event_decl ? parseInt(profiler_event_decl.minWidth) : 1;
 
   // Parent-children relationships
   this._children = {};
@@ -466,7 +466,7 @@ var ProfilerView = function(id, name, container_class, html, default_handler)
     var width = this._timeline_width;
 
     var duration = Math.max(x1 - x0, ProfilerView.MIN_DURATION);
-    var ms_unit = (width - BAR_MIN_WIDTH) / duration;
+    var ms_unit = (width - EVENT_MIN_WIDTH) / duration;
     var new_event_list = [];
     for (var i = 0, event; event = timeline_list.eventList[i]; i++)
     {