Skip to content

Commit 2e6f0d4

Browse files
committed
Fixed some review comments.
1 parent 3668489 commit 2e6f0d4

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

src/profiler/profiler_view.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,6 @@ var ProfilerView = function(id, name, container_class, html, default_handler)
174174
var aggregated_event_list = this._get_aggregated_event_list(event_list);
175175
var width = this._container.clientWidth - AGGREGATED_EVENTS_WIDTH;
176176

177-
// TODO: Check if these are already appended
178177
var frag = document.createDocumentFragment();
179178
frag.appendChild(this._legend_ele);
180179
frag.appendChild(this._zoomer_times_ele);
@@ -195,8 +194,6 @@ var ProfilerView = function(id, name, container_class, html, default_handler)
195194
this._zoomer.set_zoomer_element(this._zoomer_ele);
196195
if (this._set_zoomer)
197196
this._zoomer.set_current_area();
198-
199-
// TODO: if _set_zoomer == false, reset()
200197
};
201198

202199
this.createView = function(container)

src/ui-scripts/zoomer/zoomer.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
"use strict";
22

3-
// TODO: when width is 1px and mousewheeling, don't move
4-
53
/**
64
* @constructor
75
*/
@@ -12,6 +10,9 @@ var Zoomer = function(model, zoomer_ele)
1210

1311
var ZoomerPrototype = function()
1412
{
13+
var MOUSEWHEEL_DIFF = 5;
14+
var KEYDOWN_DIFF = 1;
15+
1516
this._init = function(model, zoomer_ele)
1617
{
1718
/**
@@ -151,7 +152,7 @@ var ZoomerPrototype = function()
151152
this._zoomer_ele_onmousewheel = function(event)
152153
{
153154
var mouse_x = event.clientX - this._zoomer_ele_left;
154-
var diff = (mouse_x < this._overlay_left) ? 5 : -5;
155+
var diff = (mouse_x < this._overlay_left) ? MOUSEWHEEL_DIFF : -MOUSEWHEEL_DIFF;
155156
diff *= (event.wheelDelta > 0) ? 1 : -1;
156157
this.move_overlay(diff);
157158
event.stopPropagation();
@@ -197,7 +198,7 @@ var ZoomerPrototype = function()
197198

198199
this._overlay_ele_onmousewheel = function(event)
199200
{
200-
var diff = (event.wheelDelta < 0) ? 5 : -5;
201+
var diff = (event.wheelDelta < 0) ? MOUSEWHEEL_DIFF : -MOUSEWHEEL_DIFF;
201202
this.change_overlay_size(diff, -diff);
202203
event.stopPropagation();
203204
};
@@ -208,8 +209,8 @@ var ZoomerPrototype = function()
208209
var diff = {
209210
33: width, // Page up
210211
34: -width, // Page down
211-
37: -1, // Arrow left
212-
39: 1 // Arrow right
212+
37: -KEYDOWN_DIFF, // Arrow left
213+
39: KEYDOWN_DIFF // Arrow right
213214
}[event.which];
214215
if (!diff)
215216
return;
@@ -279,8 +280,8 @@ var ZoomerPrototype = function()
279280
this._handle_ele_onkeydown = function(event)
280281
{
281282
var diff = {
282-
37: -1, // Arrow left
283-
39: 1 // Arrow right
283+
37: -KEYDOWN_DIFF, // Arrow left
284+
39: KEYDOWN_DIFF // Arrow right
284285
}[event.which];
285286
if (!diff)
286287
return;

0 commit comments

Comments
 (0)