Review fixes

Author: Daniel Herzog

src/network/network_details_templates.js

@@ -130,17 +130,17 @@ templates._request = function(request, is_last, do_raw)
   var settings = window.settings["network-detail-overlay"];
   var expanded = settings.get("expand-requests");
   var show_header = is_relevant;
-  var show_headers = is_relevant && expanded;
-  var show_body = show_headers;
+  var show_content = is_relevant && expanded;
 
   return [
     "div",
       show_header ? templates._headline(false, expanded) : [],
-      ["div",
-        show_headers ? templates._request_headers(request, do_raw) : [],
-        show_body ? templates._request_body(request, do_raw) : [],
-        "class", "foldable"
-      ],
+      show_content ? 
+        ["div",
+          templates._request_headers(request, do_raw),
+          templates._request_body(request, do_raw),
+          "class", "foldable"
+        ] : [],
       "class", (expanded ? "unfolded" : "")
   ];
 };
@@ -152,16 +152,18 @@ templates._response = function(response, is_last, do_raw)
   var show_header = response.logger_entry_touched_network;
   var show_headers = expanded && response.logger_entry_touched_network;
   var show_body = !show_header || (show_header && expanded);
+  var show_content = show_headers || show_body;
 
   return [
     "div",
       show_header ? this._headline(true, expanded) : [],
-      ["div",
-        show_headers ? this._response_headers(response, do_raw) : [],
-        show_body ? this._response_body(response, do_raw, is_last) : [],
-        "class", "foldable"
-      ],
-      "class", (expanded ? "unfolded" : "")
+      show_content ?
+        ["div",
+          show_headers ? this._response_headers(response, do_raw) : [],
+          show_body ? this._response_body(response, do_raw, is_last) : [],
+          "class", "foldable"
+        ] : [],
+      "class", (show_header && expanded ? "unfolded" : "")
   ];
 };
 

src/network/network_style.css

@@ -249,6 +249,11 @@
   width: 100%;
 }
 
+.network-detail-overlay .foldable
+{
+  padding: 6px 8px;
+}
+
 .network-detail-overlay .wrap /* that's .table.wrap */
 {
   display: block;
@@ -356,22 +361,20 @@
   white-space: nowrap;
 }
 
-.network-detail-overlay th .not-content
+.network-detail-overlay .not-content
 {
-  padding: 0px;
+  padding: 0;
   font-style: normal;
-  border-collapse: collapse;
   color: #808080;
   cursor: default;
-  display: block;
   font-weight: normal;
 }
 
 .network-detail-overlay th:first-child,
 .network-detail-overlay td:first-child
 {
   width: 20%;
-  padding-left: 0px;
+  padding-left: 0;
 }
 
 .network-detail-overlay tr:nth-child(even)
@@ -386,7 +389,8 @@
   margin: 7px 0 -8px 0;
 }
 
-.response-summary + div .header {
+.response-summary + div .header
+{
   border-top-width: 1px;
 }
 

src/ui-style/debugger_style.css

@@ -419,10 +419,14 @@ container > div > header,
                                     rgba(255, 255, 255, 0.45) 100%);
 }
 
-.unfolded + div header,
-.unfolded + div .header
+div.unfolded
 {
-  border-top-width: 1px;
+  border-bottom: 1px solid #ccc;
+}
+
+div.unfolded:last-child
+{
+  border-bottom-width: 0;
 }
 
 category header:hover input
@@ -441,11 +445,6 @@ header input,
   transition: 0.2s;
 }
 
-.unfolded .foldable
-{
-  padding: 6px 8px;
-}
-
 .unfolded > header input,
 .unfolded > .header input
 {

src/ui-style/ui.css

@@ -897,7 +897,6 @@ view-slider
 {
   display: block;
   position: absolute;
-  z-index: 2;
 }
 
 view-slider.vertical