Skip to content

Commit 3418445

Browse files
author
Daniel Herzog
committed
DFL-3490: "Method" is not shown in Network Logger data view
1 parent a64db0d commit 3418445

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/network/network_service.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,11 +1014,15 @@ cls.NetworkLoggerEntryPrototype = function()
10141014

10151015
this.__defineGetter__("current_response", function()
10161016
{
1017-
// In 99% of the cases, _current_response is used. It's only
1018-
// exposed for getting the ResourceInfo from the service directly.
1019-
return this.current_response;
1017+
return this._current_response;
10201018
});
10211019
this.__defineSetter__("current_response", function(){});
1020+
1021+
this.__defineGetter__("current_request", function()
1022+
{
1023+
return this._current_request;
1024+
});
1025+
this.__defineSetter__("current_request", function(){});
10221026
};
10231027

10241028
cls.NetworkLoggerEntryPrototype.prototype = new URIPrototype("url");
@@ -1037,7 +1041,7 @@ cls.NetworkLoggerRequest = function(entry)
10371041
// Set from template code, when first needed:
10381042
this.header_tokens = null;
10391043
// Belongs here, unused though:
1040-
this.request_id = entry.requestID;
1044+
this.request_id = entry.request_id;
10411045
};
10421046

10431047
cls.NetworkLoggerRequestPrototype = function()

src/network/network_view.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler,
228228
columns: {
229229
method: {
230230
label: ui_strings.S_HTTP_LABEL_METHOD,
231-
getter: function(entry) { return entry.last_method || ""; }
231+
getter: function(entry) { return (entry.current_request && entry.current_request.method) || ""; }
232232
},
233233
responsecode: {
234234
label: ui_strings.S_HTTP_LABEL_RESPONSECODE,

0 commit comments

Comments
 (0)