Review fixes.

Author: Chris K

src/build-application/build_application.js

@@ -182,7 +182,10 @@ window.app.build_application = function(on_services_created, on_services_enabled
 
   var report_usage = function()
   {
-    if (settings.general.get("track-usage") && !location.port)
+    if (settings.general.get("track-usage") &&
+        // Don't phone home when developing 
+        // (port is typically only used in that situation). 
+        !location.port)
     {
       var trackerurl = "/app/user-count"
       var tracker = new cls.UserTracker(trackerurl);

src/build-application/build_ecmascript_debugger_6_0.js

@@ -20,7 +20,7 @@ window.app.builders.EcmascriptDebugger["6.0"] = function(service)
 
     cls.InspectableJSObject = namespace.InspectableJSObject;
     cls.JSInspectionTooltip.register();
-    cls.EvListenerTooltip.register();
+    cls.EventListenerTooltip.register();
     // disabled for now. see CORE-32113
     // cls.InspectableJSObject.register_enabled_listener();
     // for now we are filtering on the client side

src/client-en.xml

@@ -212,8 +212,8 @@ window.load_screen_timeout = window.setTimeout(function()
 <script src="./lib/canvasrenderingcontext2dprototype.js"/>
 <script src="./lib/dateprototype.js"/>
 <script src="./lib/nodelistprototype.js"/>
-<script src="./lib/object.js"/>
-<script src="./lib/opera.js"/>
+<script src="./lib/objectnamespace.js"/>
+<script src="./lib/operanamespace.js"/>
 <script src="./lib/stringprototype.js"/>
 <script src="./lib/stylesheetlistprototype.js"/>
 <script src="./lib/xmlhttprequestprototype.js"/>

src/ecma-debugger/dominspection/inspectabledomnode.js

@@ -28,8 +28,8 @@ cls.EcmascriptDebugger["6.0"].InspectableDOMNode.CONTENT_DOCUMENT = 11;
 cls.EcmascriptDebugger["6.0"].InspectableDOMNode.FRAME_ELEMENT = 12;
 cls.EcmascriptDebugger["6.0"].InspectableDOMNode.MATCH_REASON = 13;
 cls.EcmascriptDebugger["6.0"].InspectableDOMNode.PSEUDO_ELEMENT = 14;
-cls.EcmascriptDebugger["6.0"].InspectableDOMNode.PSEUDO_NODE = 0;
 cls.EcmascriptDebugger["6.0"].InspectableDOMNode.EVENT_LISTENER_LIST = 15;
+cls.EcmascriptDebugger["6.0"].InspectableDOMNode.PSEUDO_NODE = 0;
 
 cls.EcmascriptDebugger["6.0"].InspectableDOMNode.prototype = new function()
 {

src/ecma-debugger/dominspection/templates.js

@@ -275,11 +275,13 @@
         case DOCUMENT_NODE:
         {
           if (ev_listener)
+          { 
             tree += "<div class='search-match dom-search document' " + 
                          "rt-id='" + String(model.getDataRuntimeId()) + "' " +
                          "obj-id='" + String(node[ID]) + "' " +
                          "handler='inspect-object-link' >" +
                       "document" + ev_listener + "</div>";
+          }
           break;
         }
         case DOCUMENT_TYPE_NODE:

src/ecma-debugger/eventlisteners/evlistenertemplates.js

@@ -68,7 +68,7 @@
   {
     var tmpl_obj_l = window.templates.ev_window_listeners(ev_type);
     var tmpl_node_l = window.templates.dom_search(ev_type);
-    return["div", tmpl_obj_l, [tmpl_node_l], "class", "ev-listener-list mono"];
+    return ["div", tmpl_obj_l, [tmpl_node_l], "class", "ev-listener-list mono"];
   };
 
   this.ev_window_listeners = function(ev_type)

src/ecma-debugger/eventlisteners/evlistenertooltip.js

@@ -2,7 +2,7 @@
 
 window.cls || (window.cls = {});
 
-cls.EvListenerTooltip = function()
+cls.EventListenerTooltip = function()
 {
   var _tooltip = null;
   var _url_tooltip = null;
@@ -50,7 +50,7 @@ cls.EvListenerTooltip = function()
 
   var _init = function(view)
   {
-    _tooltip = Tooltips.register(cls.EvListenerTooltip.tooltip_name, true);
+    _tooltip = Tooltips.register(cls.EventListenerTooltip.tooltip_name, true);
     _url_tooltip = Tooltips.register("url-tooltip", true);
     _tooltip.ontooltip = _ontooltip;
     _tooltip.onhide = _hide_tooltip;
@@ -62,9 +62,9 @@ cls.EvListenerTooltip = function()
   _init();
 };
 
-cls.EvListenerTooltip.tooltip_name = "event-listener";
+cls.EventListenerTooltip.tooltip_name = "event-listener";
 
-cls.EvListenerTooltip.register = function()
+cls.EventListenerTooltip.register = function()
 {
-  this._tooltip = new cls.EvListenerTooltip();
+  this._tooltip = new cls.EventListenerTooltip();
 };

src/ecma-debugger/js-source-view.js

@@ -466,8 +466,10 @@ cls.JsSourceView = function(id, name, container_class)
 
     line_no_end || (line_no_end = line_no_start);
     this.showLine(script_id, line_no_start);
-    this._change_highlight_class_lines("addClass", line_no_start, line_no_end);
-    var cb = this._change_highlight_class_lines.bind(this, "removeClass",
+    this._change_highlight_class_lines(Element.prototype.addClass,
+                                       line_no_start, line_no_end);
+    var cb = this._change_highlight_class_lines.bind(this,
+                                                     Element.prototype.removeClass,
                                                      line_no_start, line_no_end);
     setTimeout(cb, 1000);
   };
@@ -477,7 +479,7 @@ cls.JsSourceView = function(id, name, container_class)
     for (var i = start, line; i <= end; i++)
     {
       if (line = this.get_line_element(i))
-        line[method]("selected-js-source-line");
+        method.call(line, "selected-js-source-line");
     }
   };
 
@@ -511,11 +513,10 @@ cls.JsSourceView = function(id, name, container_class)
   this.showLine = function(script_id, line_no, is_parse_error, is_scroll)
   {
     if (__timeout_clear_view)
-    {
       __timeout_clear_view = clearTimeout(__timeout_clear_view);
-    }
 
-    var is_visible = (source_content = document.querySelector(CONTAINER_SELECTOR)) ? true : false;
+    source_content = document.querySelector(CONTAINER_SELECTOR);
+    var is_visible = Boolean(source_content);
     // if the view is visible it shows the first new script
     // before any parse error, that means in case of a parse error
     // the current script has not set the parse_error property
@@ -804,7 +805,8 @@ cls.JsSourceView = function(id, name, container_class)
 
   var __clearView = function()
   {
-    if( ( source_content = document.querySelector(CONTAINER_SELECTOR) ) && source_content.parentElement )
+    source_content = document.querySelector(CONTAINER_SELECTOR);
+    if (source_content && source_content.parentElement)
     {
       var
       divs = source_content.parentElement.parentElement.getElementsByTagName('div'),
@@ -1031,6 +1033,7 @@ cls.JsSourceView.update_breakpoints = function(script, line_numbers, top_line)
       var span = line_numbers.querySelector(".line-number");
       top_line = span && Number(span.textContent);
     }
+    
     if (lines && bp_states && typeof top_line == "number")
     {
       for (var i = 0, line; line = lines[i]; i++)

src/ecma-debugger/newscript.js

@@ -238,6 +238,7 @@ window.cls.NewScriptPrototype = function()
           }
         }
       }
+      
       if (end_line == -1)
       {
         index = 0;

src/ecma-debugger/objectinspection.6.0/prettyprinter.js

@@ -133,6 +133,7 @@ cls.PrettyPrinter.types[cls.PrettyPrinter.FUNCTION] =
                      "data-script-endline", String(end_line)),
         head = ["h2", sc_link, "class", "js-tooltip-title"];
       }
+
       for (var i = start_line; i <= end_line; i++)
       {
         var data = script.get_line(i);
@@ -236,12 +237,13 @@ cls.PrettyPrinter.prototype = new function()
 
     list.forEach(function(type)
     {
+      var type_obj = cls.PrettyPrinter.types[type];
       if (cls.PrettyPrinter.types.hasOwnProperty(type) &&
-          !this._types.contains(cls.PrettyPrinter.types[type]))
+          !this._types.contains(type_obj))
       {
-        this._types.push(cls.PrettyPrinter.types[type]);
-        if (cls.PrettyPrinter.types[type].init)
-          cls.PrettyPrinter.types[type].init();
+        this._types.push(type_obj);
+        if (type_obj.init)
+          type_obj.init();
       }
     }, this);  
   };