Skip to content

Commit 653dfc1

Browse files
author
Chris K
committed
Review fixes.
1 parent 43d114c commit 653dfc1

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

src/cookie-manager/cookie_manager_data.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ cls.CookieManager.CookieDataBase = function()
167167
delete this._rts[rt_id];
168168
this.cookie_list = this.cookie_list.filter(function(cookie)
169169
{
170-
return !(cookie.rt_id == rt_id);
170+
return cookie.rt_id != rt_id;
171171
});
172172
}
173173
}
@@ -280,7 +280,7 @@ cls.CookieManager.CookieDataBase = function()
280280

281281
if (status === SUCCESS)
282282
{
283-
const COOKIE = 0;
283+
var COOKIE = 0;
284284
if (message.length > 0)
285285
{
286286
var cookies = message[COOKIE];

src/ecma-debugger/objectinspection.6.0/inspectablejsobject.js

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -128,16 +128,12 @@ cls.EcmascriptDebugger["6.0"].InspectableJSObject.prototype = new function()
128128
var PATH_KEY = 0;
129129
var PATH_OBJ_ID = 1;
130130
var PATH_PROTO_INDEX = 2;
131-
var key = "";
132-
var obj_id = 0;
133-
var proto_index = 0;
134131
var tree = this._expand_tree;
135-
var index = 0;
136-
for (var i = 0 ; path && path[i]; i++)
132+
for (var i = 0; path && path[i]; i++)
137133
{
138-
key = path[i][PATH_KEY];
139-
obj_id = path[i][PATH_OBJ_ID];
140-
index = path[i][PATH_PROTO_INDEX];
134+
var key = path[i][PATH_KEY];
135+
var obj_id = path[i][PATH_OBJ_ID];
136+
var index = path[i][PATH_PROTO_INDEX];
141137
if (i < (path.length - 1) && !(tree.get_chain(["protos", index, key])))
142138
throw "not valid path in InspectableJSObject._get_subtree";
143139

@@ -162,16 +158,13 @@ cls.EcmascriptDebugger["6.0"].InspectableJSObject.prototype = new function()
162158
var PATH_KEY = 0;
163159
var PATH_OBJ_ID = 1;
164160
var PATH_PROTO_INDEX = 2;
165-
var key = "";
166-
var obj_id = 0;
167-
var proto_index = 0;
168161
var tree = this._expand_tree;
169162
var ret = null;
170-
for (var i = 0 ; path && path[i]; i++)
163+
for (var i = 0; path && path[i]; i++)
171164
{
172-
key = path[i][PATH_KEY];
173-
obj_id = path[i][PATH_OBJ_ID];
174-
index = path[i][PATH_PROTO_INDEX];
165+
var key = path[i][PATH_KEY];
166+
var obj_id = path[i][PATH_OBJ_ID];
167+
var index = path[i][PATH_PROTO_INDEX];
175168
var sub_tree = tree.get_chain(["protos", index, key]);
176169
if (!sub_tree)
177170
{

src/ecma-debugger/objectinspection.6.0/templates.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828

2929
/* private */
3030

31-
var _has_own_prop = Object.prototype.hasOwnProperty;
32-
3331
var _is_unfolded = function(tree, index, name, collapsed_protos)
3432
{
3533
if (!index) // the properties of the object itself

src/lib/dict.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,15 @@ Dict.prototype = new function()
3131
return keys;
3232
};
3333

34+
this.setdefault = function(key, value)
35+
{
36+
if (this._dict.hasOwnProperty(PREFIX + key))
37+
return this.get(key);
38+
39+
this.set(key, value);
40+
return value;
41+
};
42+
3443
this.toString = function()
3544
{
3645
var rep = [];
@@ -39,7 +48,7 @@ Dict.prototype = new function()
3948
var value = this._dict[key];
4049
value = typeof value == "string" ? "\"" + value + "\"" : String(value);
4150
key = key.slice(PREFIX.length);
42-
rep.push(rep.length ? ", " : "", "\"", key, "\": ", value);
51+
rep.push((rep.length ? ", " : ""), "\"", key, "\": ", value);
4352
}
4453
return "{" + rep.join("") + "}";
4554
};

0 commit comments

Comments
 (0)