Skip to content

Commit 73f827f

Browse files
author
p01
committed
Fix for DFL-3719, Search in Detail view should be limited to content
Add a resource-detail-text-container class for good measure
1 parent 182cc82 commit 73f827f

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/resource-manager/resource_detail_view.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,9 @@ cls.ResourceDetailView.create_ui_widgets = function()
214214
});
215215

216216
var text_search = window.views.resource_detail_view.text_search = new TextSearch();
217+
var TEXT_RESOURCE_DETAIL_CONTAINER_CLASSNAMES = ["markup", "css", "script", "text"].map( function(v) {
218+
return ".resource-detail-" + v +"-container";
219+
});
217220

218221
window.event_handlers.input["resource-text-search"] = function(event, target)
219222
{
@@ -229,7 +232,8 @@ cls.ResourceDetailView.create_ui_widgets = function()
229232
{
230233
if (msg.id === "resource_detail_view")
231234
{
232-
var scroll_container = msg.container.querySelector(".resource-detail-container");
235+
var scroll_container = msg.container.querySelector(TEXT_RESOURCE_DETAIL_CONTAINER_CLASSNAMES);
236+
233237
if (scroll_container)
234238
{
235239
text_search.setContainer(scroll_container);

src/resource-manager/resource_style.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@
184184

185185
.resource-detail-script-container,
186186
.resource-detail-css-container,
187-
.resource-detail-markup-container
187+
.resource-detail-markup-container,
188+
.resource-detail-text-container
188189
{
189190
position: absolute;
190191
top: 55px;

0 commit comments

Comments
 (0)