Skip to content

Commit 74c6997

Browse files
author
Daniel Herzog
committed
Review fix
1 parent a77d5ad commit 74c6997

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

src/network/network_details_templates.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -201,14 +201,14 @@ templates._request_headers = function(req, do_raw)
201201
return this._pre(this.headers_tonkenized(header_tokens, false));
202202
}
203203
return ["span", ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL,
204-
"class", templates.UI_CLASSNAME];
204+
"class", templates.UI_CLASSNAMES];
205205
}
206206

207207
var ret = [];
208208
if (!req.request_headers)
209209
{
210210
ret.push(["span", ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL,
211-
"class", templates.UI_CLASSNAME]);
211+
"class", templates.UI_CLASSNAMES]);
212212
}
213213
else
214214
{
@@ -286,7 +286,7 @@ templates._response_headers = function(resp, do_raw)
286286
return this._pre(this.headers_tonkenized(header_tokens, true));
287287
}
288288
return ["span", ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL,
289-
"class", templates.UI_CLASSNAME];
289+
"class", templates.UI_CLASSNAMES];
290290
}
291291

292292
var ret = resp.response_headers && resp.response_headers.map(this._headers_pseudo_raw);
@@ -302,7 +302,7 @@ templates._response_headers = function(resp, do_raw)
302302
if (!ret)
303303
{
304304
ret = ["span", ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL,
305-
"class", templates.UI_CLASSNAME];
305+
"class", templates.UI_CLASSNAMES];
306306
}
307307
return templates._pre(ret);
308308
};
@@ -364,7 +364,7 @@ templates._request_body = function(req, do_raw)
364364
ret.push(part.content.stringData);
365365
else
366366
ret.push(["span", ui_strings.S_NETWORK_N_BYTE_BODY.replace("%s", part.contentLength),
367-
"class", templates.UI_CLASSNAME]);
367+
"class", templates.UI_CLASSNAMES]);
368368

369369
if (use_raw_boundary && part === req.request_body.partList.last)
370370
raw_boundary += "--";
@@ -388,8 +388,8 @@ templates._request_body = function(req, do_raw)
388388
var rows = [];
389389
rows.push([
390390
"tr",
391-
["th", ["span", ui_strings.S_LABEL_NETWORK_POST_DATA_NAME, "class", templates.UI_CLASSNAME]],
392-
["th", ["span", ui_strings.S_LABEL_NETWORK_POST_DATA_VALUE, "class", templates.UI_CLASSNAME]]
391+
["th", ["span", ui_strings.S_LABEL_NETWORK_POST_DATA_NAME, "class", templates.UI_CLASSNAMES]],
392+
["th", ["span", ui_strings.S_LABEL_NETWORK_POST_DATA_VALUE, "class", templates.UI_CLASSNAMES]]
393393
]
394394
);
395395
rows.extend(parts.map(this.param_cells));
@@ -411,12 +411,12 @@ templates._request_body = function(req, do_raw)
411411
if (req.request_body.mimeType)
412412
{
413413
ret = ["span", ui_strings.S_NETWORK_CANT_DISPLAY_TYPE.replace("%s", req.request_body.mimeType),
414-
"class", templates.UI_CLASSNAME];
414+
"class", templates.UI_CLASSNAMES];
415415
}
416416
else
417417
{
418418
ret = ["span", ui_strings.S_NETWORK_UNKNOWN_MIME_TYPE,
419-
"class", templates.UI_CLASSNAME];
419+
"class", templates.UI_CLASSNAMES];
420420
}
421421
}
422422
}
@@ -470,7 +470,7 @@ templates._response_body = function(resp, do_raw, is_last_response)
470470
{
471471
ret.push(
472472
["span", ui_strings.S_NETWORK_REQUEST_DETAIL_UNDISPLAYABLE_BODY_LABEL.replace("%s", resp.logger_entry_mime),
473-
"class", templates.UI_CLASSNAME]
473+
"class", templates.UI_CLASSNAMES]
474474
);
475475
}
476476
}

src/network/network_style.css

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -359,9 +359,6 @@
359359
.network-detail-overlay .not-content
360360
{
361361
padding: 0;
362-
font: menu;
363-
font-size: 11px;
364-
font-style: normal;
365362
color: #808080;
366363
cursor: default;
367364
font-weight: normal;

src/network/network_templates.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var GRAPH_PADDING = (TIMELINE_MARKER_WIDTH / 2) + MIN_BAR_WIDTH + SECTIONS_HITAR
1313
var UNREFERENCED = templates.UNREFERENCED = "unreferenced";
1414
var ERROR_RESPONSE = templates.ERROR_RESPONSE = "error_response";
1515
var NOT_REQUESTED = templates.NOT_REQUESTED = "not_requested";
16-
var UI_CLASSNAME = templates.UI_CLASSNAME = "not-content";
16+
var UI_CLASSNAMES = templates.UI_CLASSNAMES = "not-content ui-font";
1717

1818
templates.options_main = function(nocaching, tracking, headers, overrides)
1919
{

src/ui-style/ui.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
/* Font stack defaults */
22
viewport,
33
.info-box,
4-
.ui-button {
4+
.ui-button,
5+
.ui-font
6+
{
57
font-family: sans-serif;
68
font: menu;
79
font-style: normal;

0 commit comments

Comments
 (0)