Skip to content

Commit 8d63820

Browse files
committed
Fix DFL-3374: Tooltip is not placed correctly if the target element is very high and on the right side of the viewport.
1 parent ee973a0 commit 8d63820

File tree

2 files changed

+22
-17
lines changed

2 files changed

+22
-17
lines changed

src/ecma-debugger/templates.js

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@
471471
return [
472472
["li",
473473
["div",
474-
["span",
474+
["div",
475475
"↱",
476476
"class", "return-value-arrow return-value-arrow-from",
477477
"handler", "goto-script-line",
@@ -487,14 +487,17 @@
487487
],
488488
(value_template.length
489489
? ["div",
490-
["span",
491-
"↳",
492-
"class", "return-value-arrow return-value-arrow-to",
490+
["div",
491+
["div",
492+
"↳",
493+
"class", "return-value-arrow-to",
494+
"data-tooltip", "return-value-tooltip",
495+
"data-tooltip-text", ui_strings.S_RETURN_VALUES_FUNCTION_TO
496+
.replace("%s", to_uri)
497+
.replace("%s", retval.positionTo.lineNumber)
498+
],
499+
"class", "return-value-arrow",
493500
"handler", "goto-script-line",
494-
"data-tooltip", "return-value-tooltip",
495-
"data-tooltip-text", ui_strings.S_RETURN_VALUES_FUNCTION_TO
496-
.replace("%s", to_uri)
497-
.replace("%s", retval.positionTo.lineNumber),
498501
"data-script-id", String(retval.positionTo.scriptID),
499502
"data-script-line", String(retval.positionTo.lineNumber)
500503
],

src/ui-style/debugger_style.css

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,11 +1639,6 @@ d
16391639
display: table-cell;
16401640
}
16411641

1642-
.return-value .return-value-arrow-to
1643-
{
1644-
padding-left: 14px;
1645-
}
1646-
16471642
.return-function-from .folder-key
16481643
{
16491644
display: none;
@@ -1653,21 +1648,28 @@ d
16531648
{
16541649
display: inline-block;
16551650
vertical-align: top;
1656-
width: 15px;
1657-
height: 16px;
1651+
width: 14px;
1652+
height: 15px;
16581653
background-repeat: no-repeat;
16591654
cursor: pointer;
1660-
content: "";
1655+
}
1656+
1657+
.return-value .return-value-arrow
1658+
{
1659+
width: 28px;
16611660
}
16621661

16631662
.return-value-arrow-from
16641663
{
1664+
content: "";
16651665
background: transparent url("../ui-images/arrow_roundl.png") 0 50% no-repeat;
16661666
}
16671667

16681668
.return-value-arrow-to
16691669
{
1670-
background: transparent url("../ui-images/arrow_tail.png") 14px 2px no-repeat;
1670+
content: "";
1671+
height: 100%;
1672+
background: transparent url("../ui-images/arrow_tail.png") 13px 2px no-repeat;
16711673
}
16721674

16731675
.return-function-from:hover .return-value-arrow-from

0 commit comments

Comments
 (0)