Review fixes

Author: Daniel Herzog

src/scripts/dom.js

@@ -781,14 +781,15 @@ Date.fromLocaleISOString = function(localeISOString)
 {
   // A localeISOString looks like one of these:
     // 2012-08-03T16:11
-    // 2012-08-03T16:11:52.61 (the it's CORE-47780)
-    // 2012-08-03T16:11:52.611
+    // 2012-08-03T16:11:52.2
+    // 2012-08-03T16:11:52.12 (CORE-47780)
+    // 2012-08-03T16:11:52.612
 
-  var parts = /^(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2})(?::(\d{2})\.(\d{2,3}))?$/.exec(localeISOString);
+  var parts = /^(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2})(?::(\d{2})\.(\d+))?$/.exec(localeISOString);
   if (parts)
   {
     parts.shift();
-    var date = new Date(0);
+    var date = new Date();
     [
       // setXyz methods are used to set local timezone, as opposed to setXyzUTC
       date.setFullYear,
@@ -800,11 +801,8 @@ Date.fromLocaleISOString = function(localeISOString)
       date.setMinutes,
       date.setSeconds,
       date.setMilliseconds
-    ].forEach(function(func){
-      var val = parts.shift();
-      if (val)
-        func.call(date, Number(val));
-
+    ].forEach(function(func, i){
+      func.call(date, Number(parts[i] || 0));
     });
     return date;
   }

tests/locale_iso_strings.html

@@ -31,6 +31,9 @@
   var t = Date.fromLocaleISOString("2012-08-03T17:00:00.00").getTime();
   equal(t, 1344013200000 + TIMEZONE_OFFSET);
 
+  var t = Date.fromLocaleISOString("2012-08-03T17:00:00.0").getTime();
+  equal(t, 1344013200000 + TIMEZONE_OFFSET);
+
 });