Moved to overlay view for network-details

Author: Daniel Herzog

src/network/network_details_templates.js

@@ -13,28 +13,14 @@ templates._pre = function(content)
   return ["pre", content, "class", "mono"];
 };
 
-templates.details = function(entry, left_val, do_raw, do_wrap)
+templates.details = function(entry, do_raw, do_wrap)
 {
   return (
     ["div",
-      [
-        ["span",
-          "class", "resize-request-detail",
-          "handler", "resize-request-detail"
-        ],
-        ["div",
-          ["div",
-            this._details_headline(entry),
-            this._details_content(entry, do_raw),
-            "class", "table-cell"
-          ],
-          "data-object-id", String(entry.id),
-          "class", "entry-details"
-        ]
-      ],
-    "class", "network-details-container" + 
-             (do_wrap ? " network-details-container-wrap" : ""),
-    "style", "left:" + left_val + "px"]
+      this._details_headline(entry),
+      this._details_content(entry, do_raw),
+      "class", "table-cell" + (do_wrap ? " wrap" : "")
+    ]
   );
 };
 
@@ -117,7 +103,7 @@ templates._request = function(request, is_last, do_raw)
   // and didn't go on the network.
   var is_relevant = is_last && request.was_responded_to;
 
-  var expanded = window.settings.network_logger.get("expand-requests");
+  var expanded = window.settings["network-detail-overlay"].get("expand-requests");
   var show_headline = is_relevant;
   var show_headers = is_relevant && expanded;
   var show_body = show_headers;
@@ -131,7 +117,7 @@ templates._request = function(request, is_last, do_raw)
 
 templates._response = function(response, is_last, do_raw)
 {
-  var expanded = window.settings.network_logger.get("expand-responses");
+  var expanded = window.settings["network-detail-overlay"].get("expand-responses");
   var show_headline = response.logger_entry_touched_network;
   var show_headers = expanded && response.logger_entry_touched_network;
   var show_body = expanded;

src/network/network_style.css

@@ -244,35 +244,20 @@
   cursor: col-resize;
 }
 
-.network-details-container
+.network-details-view
 {
-  position: absolute;
-  right: 0;
-  top: 0;
-  height: 100%;
-  z-index: 2;
-  left: 120px;
-  background-color: #fff;
-  box-shadow: 0 5px 6px rgba(0, 0, 0, 0.39),
-              0 2px 2px 1px rgba(0, 0, 0, 0.28),
-              -1px 0 0 rgba(0, 0, 0, 0.05);
-}
-
-.network_logger .entry-details
-{
-  overflow: auto;
   height: 100%;
   padding: 0 5px;
   box-sizing: border-box;
   overflow: auto;
 }
 
-.network-details-container .table-cell
+.network-details-view .table-cell
 {
   display: table-cell;
 }
 
-.network-details-container-wrap .table-cell
+.network-details-view .wrap /* that's .table-cell.wrap */
 {
   display: block;
 }
@@ -282,22 +267,22 @@
   white-space: pre;
 }
 
-.network-details-container-wrap .method-and-url
+.network-details-view .wrap .method-and-url
 {
   word-wrap: break-word;
 }
 
-.network-details-container .header-token-type-first_line_part
+.network-details-view .header-token-type-first_line_part
 {
   font-weight: bold;
 }
 
-.network_logger .header-token-type-name
+.network-details-view .header-token-type-name
 {
   color: #149CBD;
 }
 
-.network_logger .http-token-type-boundary
+.network-details-view .http-token-type-boundary
 {
   color: #7E7E7E;
 }
@@ -310,87 +295,87 @@
   color: #808080;
 }
 
-.network-details-container pre,
-.network-details-container p
+.network-details-view pre,
+.network-details-view p
 {
   margin: 0;
 }
 
-.network-details-container-wrap pre,
-.network-details-container-wrap p,
-.network-details-container-wrap td
+.network-details-view .wrap pre,
+.network-details-view .wrap p,
+.network-details-view .wrap td
 {
   word-wrap: break-word;
   white-space: pre;
 }
 
-.network-details-container-wrap td
+.network-details-view .wrap td
 {
   /* not entirely sure why only pre-wrap helps here */
   white-space: pre-wrap;
 }
 
-.network-details-container-wrap img {
+.network-details-view .wrap img {
   max-width: 100%;
 }
 
-.network-details-container p
+.network-details-view p
 {
   font: 11px "menu";
 }
 
-.network-details-container table
+.network-details-view table
 {
   border-collapse: collapse;
 }
 
-.network-details-container table
+.network-details-view table
 {
   width: 1px;
 }
 
-.network-details-container-wrap table
+.network-details-view .wrap table
 {
   width: 100%;
 }
 
-.network-details-container td,
-.network-details-container th
+.network-details-view td,
+.network-details-view th
 {
   vertical-align: top;
 }
 
-.network-details-container th
+.network-details-view th
 {
   text-align: left;
   white-space: nowrap;
 }
 
-.network-details-container th:first-child,
-.network-details-container td:first-child
+.network-details-view th:first-child,
+.network-details-view td:first-child
 {
   width: 20%;
   padding-right: 30px;
 }
 
-.network-details-container hr
+.network-details-view hr
 {
   border: none;
   border-top: 1px solid #a4a4a4;
   margin: 7px 0 -8px 0;
 }
 
+.network-details-view div.header {
+  margin: 0 0 0 -5px; /* todo: 10px 0 10px -5px; looks better to me but is inconsistent with dom panel headers */
+}
+
 .request-crafter h2,
 .network-options h2
 {
   font-size: 125%;
   padding: 10px 0 5px 0;
 }
 
-.network-details-container div.header {
-  margin: 0 0 0 -5px; /* todo: 10px 0 10px -5px; looks better to me but is inconsistent with dom panel headers */
-}
-
 .network_logger .network-main-container .sortable-table .network-graph-column
 {
   line-height: 0;