DFL-3675: Setting breakpoints from JS source tooltip is broken, sets them in the wrong place

Daniel Herzog · Daniel Herzog · commit a4bf12ad82f5 · 2012-10-29T12:51:31.000+01:00
diff --git a/src/ecma-debugger/action_handler.js b/src/ecma-debugger/action_handler.js
@@ -184,8 +184,8 @@ window.eventHandlers.click['set-break-point'] = function(event)
       var span = li.querySelector(".line-number");
       line_number = span && Number(span.textContent);
     }
-    var script_id = window.views.js_source.getCurrentScriptId() ||
-                    Number(target.get_ancestor_attr("data-script-id"));
+    var script_id = Number(target.get_ancestor_attr("data-script-id")) ||
+                    window.views.js_source.getCurrentScriptId();
     if (script_id && line_number)
     {
       if (bps.script_has_breakpoint_on_line(script_id, line_number))

Original file line number	Diff line number	Diff line change
`@@ -184,8 +184,8 @@ window.eventHandlers.click['set-break-point'] = function(event)`
`184`	`184`	`var span = li.querySelector(".line-number");`
`185`	`185`	`line_number = span && Number(span.textContent);`
`186`	`186`	`}`
`187`		`- var script_id = window.views.js_source.getCurrentScriptId() \|\|`
`188`		`- Number(target.get_ancestor_attr("data-script-id"));`
	`187`	`+ var script_id = Number(target.get_ancestor_attr("data-script-id")) \|\|`
	`188`	`+ window.views.js_source.getCurrentScriptId();`
`189`	`189`	`if (script_id && line_number)`
`190`	`190`	`{`
`191`	`191`	`if (bps.script_has_breakpoint_on_line(script_id, line_number))`