(A good bunch of) Review fixes.

Author: Daniel Herzog

src/build-application/build_resource_manager_1_0.js

@@ -2,11 +2,16 @@
 
 window.app.builders.ResourceManager["1.0"] = function(service)
 {
-  window.network_logger = new cls.NetworkLoggerService();
+  var logger_service = new cls.NetworkLoggerService();
   new cls.ResourceManagerAllView("resource_all", ui_strings.M_VIEW_LABEL_ALL_RESOURCES, "scroll resource-manager", "", "");
   //new cls.ResourceManagerFontView('resource_fonts', "Fonts", 'scroll', '', '');
   //new cls.ResourceManagerImageView('resource_images', "Images", 'scroll', '', '');
-  new cls.NetworkLogView("network_logger", ui_strings.M_VIEW_LABEL_NETWORK_LOG, "scroll network_logger", null, "network-logger");
+  new cls.NetworkLogView("network_logger", 
+                         ui_strings.M_VIEW_LABEL_NETWORK_LOG,
+                         "scroll network_logger",
+                         null,
+                         "network-logger",
+                         logger_service);
   new cls.RequestCraftingView("request_crafter", ui_strings.M_VIEW_LABEL_REQUEST_CRAFTER, "scroll", "", "");
   new cls.NetworkOptionsView("network_options",
                              ui_strings.M_VIEW_LABEL_NETWORK_OPTIONS,

src/ecma-debugger/helpers.js

@@ -368,14 +368,14 @@ window.cls.Helpers = function()
 
   this.prop = (function()
   {
-   var cache = {};
-   return function(prop)
-   {
-     return cache[prop] || (cache[prop] = function(obj)
-     {
-       return obj[prop];
-     });
-   };
+    var cache = {};
+    return function(prop)
+    {
+      return cache[prop] || (cache[prop] = function(obj)
+      {
+        return obj[prop];
+      });
+    };
   })();
 
   this.eq = function(prop, val)
@@ -384,7 +384,7 @@ window.cls.Helpers = function()
     {
       return obj[prop] === val;
     };
-  }
+  };
 }
 
 cls.Helpers.shortcut_search_cb = function(action_id, event, target)

src/ecma-debugger/runtimes.js

@@ -1332,15 +1332,15 @@ cls.EcmascriptDebugger["6.0"].Runtimes = function(service_version)
     return  __scripts[scriptId] && __scripts[scriptId].runtime_id || null;
   }
 
-  this.reloadWindow = function(passed_window)
+  this.reloadWindow = function(window_id)
   {
-    var sel_window = passed_window || __selected_window;
-    if (sel_window)
+    __selected_window = window_id || __selected_window;
+    if (__selected_window)
     {
-      if (!__windows_reloaded[sel_window])
-        __windows_reloaded[sel_window] = 1;
+      if (!__windows_reloaded[__selected_window])
+        __windows_reloaded[__selected_window] = 1;
 
-      var rt_id = this.getRuntimeIdsFromWindow(sel_window)[0];
+      var rt_id = this.getRuntimeIdsFromWindow(__selected_window)[0];
       if (window.services['ecmascript-debugger'] &&
           window.services['ecmascript-debugger'].is_enabled &&
           // For background processes we can not use the exec service.

src/ecma-debugger/views.js

@@ -477,7 +477,7 @@ cls.MainView .create_ui_widgets = function()
 
   eventHandlers.click['reload-window'] = function(event, target)
   {
-    var window_id = target.get_attr("parent-node-chain", "data-reload-window-id");
+    var window_id = Number(target.get_attr("parent-node-chain", "data-reload-window-id"));
     runtimes.reloadWindow(window_id);
   }
 }