Skip to content

Commit bbdca20

Browse files
committed
DFL-2502 Address review issues.
1 parent 1f5c4a2 commit bbdca20

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

src/ecma-debugger/js-source-view.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -983,8 +983,8 @@ cls.JsSourceView = function(id, name, container_class)
983983

984984
var _last_delta = 0;
985985
var _accumulated_delta = 0;
986-
const UNIT_LINES = 1;
987-
const UNIT_PIXELS = 2;
986+
var UNIT_LINES = 1;
987+
var UNIT_PIXELS = 2;
988988

989989
this._get_lines_from_delta = function(delta, unit)
990990
{
@@ -1007,17 +1007,14 @@ cls.JsSourceView = function(id, name, container_class)
10071007
// Enough delta to scroll at least one line, round delta
10081008
// to full integer towards 0 and store remainder for later.
10091009
lines = delta > 0 ? Math.floor(delta) : Math.ceil(delta);
1010-
_accumulated_delta = delta % 1;
1010+
_accumulated_delta -= _lines * window.defaults["js-source-line-height"];
10111011
}
1012-
else
1013-
// Not enough delta accumulated to scroll.
1014-
lines = 0;
10151012
}
10161013

10171014
return lines;
10181015
}
10191016

1020-
eventHandlers.mousewheel['scroll-js-source-view'] = function(unit, event, target)
1017+
window.eventHandlers.mousewheel['scroll-js-source-view'] = function(unit, event, target)
10211018
{
10221019
if (event.wheelDeltaX !== undefined && event.wheelDeltaX != 0)
10231020
// Horizontal scrolling is handled natively by the browser.
@@ -1350,7 +1347,7 @@ cls.JsSourceView.create_ui_widgets = function()
13501347

13511348
new Switches ('js_source', switches);
13521349

1353-
eventHandlers.change['set-tab-size'] = function(event, target)
1350+
window.eventHandlers.change['set-tab-size'] = function(event, target)
13541351
{
13551352
var
13561353
style = document.styleSheets.getDeclaration(DIV_SELECTOR),
@@ -1363,7 +1360,7 @@ cls.JsSourceView.create_ui_widgets = function()
13631360
}
13641361
}
13651362

1366-
eventHandlers.change['set-max-search-hits'] = function(event, target)
1363+
window.eventHandlers.change['set-max-search-hits'] = function(event, target)
13671364
{
13681365
var max_search_hits = Number(event.target.value);
13691366
if (100 < max_search_hits && max_search_hits < 10000)
@@ -1372,7 +1369,7 @@ cls.JsSourceView.create_ui_widgets = function()
13721369
}
13731370
}
13741371

1375-
eventHandlers.click['show-event-breakpoint-view'] = function(event, target)
1372+
window.eventHandlers.click['show-event-breakpoint-view'] = function(event, target)
13761373
{
13771374
var view = window.views['event-breakpoints'];
13781375
UIWindowBase.showWindow(view.id,

0 commit comments

Comments
 (0)