DFL-3478 Using Dragonfly from file:// with XHR throws in Settings > About

Author: Christian Krebs

src/ecma-debugger/views.js

@@ -79,17 +79,29 @@ cls.AboutView.create_ui_widgets = function()
       about:
       function(setting)
       {
-        new XMLHttpRequest().loadResource('AUTHORS', function(xml)
+        var on_about_sucess = function(xml)
         {
-          var
-          authors = document.getElementById('about-authors'),
-          response_text = xml.responseText;
-          if(authors && response_text)
-          {
+          var authors = document.getElementById('about-authors');
+          var response_text = xml.responseText;
+          if (authors && response_text)
             authors.textContent = response_text;
+        };
+
+        var on_about_error = function()
+        {
+          var authors = document.getElementById('about-authors');
+          if (authors)
+          {
+            var tmpl = ["a", ui_strings.S_CONTRIBUTORS,
+                             "target", "_blank",
+                             "style", "color: inherit",
+                             "href", "https://github.com/operasoftware/dragonfly/blob/master/AUTHORS"];
+            authors.render(tmpl);
           }
-        });
-        return ['ul', ['li', 'id', 'about-authors', 'class', 'padding selectable']];
+        };
+
+        new XMLHttpRequest().loadResource("AUTHORS", on_about_sucess, null, on_about_error);
+        return ["ul", ["li", "id", "about-authors", "class", "padding selectable"]];
       }
     },
     "about"

src/lib/usertracker.js

@@ -31,7 +31,7 @@ cls.UserTracker = function(url, storagekey)
 
     conn.onreadystatechange = rshandler;
     conn.open("GET", url, true);
-    conn.send(null);
+    try { conn.send(null); } catch(e) {};
   }
 
 

src/lib/xmlhttprequestprototype.js

@@ -5,12 +5,18 @@
  * "this" value
  */
 
-XMLHttpRequest.prototype.loadResource = function(url, callback, context)
+XMLHttpRequest.prototype.loadResource = function(url, callback, context, error_callback)
 {
   this.onload = function()
   {
     callback(this, context);
-  }
+  };
+
+  this.onerror = function()
+  {
+    setTimeout(error_callback, 0, context);
+  };
+
   this.open('GET', url);
-  this.send(null);
+  try { this.send(null); } catch(e) {};
 };

src/ui-strings/ui_strings-en.js

@@ -1746,3 +1746,7 @@ ui_strings.S_TOGGLE_PAUSED_UPDATING_NETWORK_VIEW = "Pause updating network activ
 /* DESC: String shown instead of filename when file name is missing  */
 ui_strings.S_UNKNOWN_SCRIPT = "(Unknown script)";
 
+/* DESC: Text for a link to the contributors list. */
+ui_strings.S_CONTRIBUTORS = "Contributors";
+
+