Skip to content

Commit d7cc8d0

Browse files
committed
Check for event.key instead of event.which in keydown events.
1 parent 36efbe1 commit d7cc8d0

File tree

1 file changed

+18
-11
lines changed

1 file changed

+18
-11
lines changed

src/ui-scripts/zoomer/zoomer.js

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -207,20 +207,23 @@ var ZoomerPrototype = function()
207207
if (this._handle_ele)
208208
return;
209209

210+
if (!event.key)
211+
return;
212+
210213
var width = this._to_right_x(this._overlay_right) - this._overlay_left;
211214
var diff = {
212-
33: width, // Page up
213-
34: -width, // Page down
214-
37: -KEYDOWN_DIFF, // Arrow left
215-
39: KEYDOWN_DIFF // Arrow right
216-
}[event.which];
215+
"PageUp": width,
216+
"PageDown": -width,
217+
"Left": -KEYDOWN_DIFF,
218+
"Right": KEYDOWN_DIFF
219+
}[event.key];
217220
if (diff)
218221
this.move_overlay(diff);
219222

220223
diff = {
221-
38: -KEYDOWN_DIFF, // Arrow up
222-
40: KEYDOWN_DIFF // Arrow down
223-
}[event.which];
224+
"Up": -KEYDOWN_DIFF,
225+
"Down": KEYDOWN_DIFF
226+
}[event.key];
224227
if (diff)
225228
this.change_overlay_size(-diff, diff);
226229

@@ -287,10 +290,14 @@ var ZoomerPrototype = function()
287290

288291
this._handle_ele_onkeydown = function(event)
289292
{
293+
if (!event.key)
294+
return;
295+
290296
var diff = {
291-
37: -KEYDOWN_DIFF, // Arrow left
292-
39: KEYDOWN_DIFF // Arrow right
293-
}[event.which];
297+
"Left": -KEYDOWN_DIFF,
298+
"Right": KEYDOWN_DIFF
299+
}[event.key];
300+
294301
if (!diff)
295302
return;
296303
var is_left_handle = this._handle_ele == this._handle_left_ele;

0 commit comments

Comments
 (0)