Skip to content

Commit dab6f89

Browse files
author
p01
committed
Fix for DFL-3728, Opening link ot CSS file at Documents tab doesn't scroll it to relevant line in Resources tab
1 parent ed5a4de commit dab6f89

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/resource-manager/resource_detail_view.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ cls.ResourceDetailView = function(id, name, container_class, html, default_handl
2525
container.clearAndRender(window.templates.disabled_view());
2626
};
2727

28+
this.TEXT_RESOURCE_DETAIL_CONTAINER_SELECTOR = ["markup", "css", "script", "text"].map(function(v) {
29+
return ".resource-detail-" + v + "-container";
30+
});
2831
var HIGHLIGHTED_LINE_CLASSNAME = "highlighted-line";
29-
var RESOURCE_DETAIL_CONTAINER_CLASSNAME = "resource-detail-container";
3032
var TEXT = document.TEXT_NODE;
3133
var ELE = document.ELEMENT_NODE;
3234
var HIGHLIGHT_CONTEXT_SIZE = 8;
@@ -117,7 +119,7 @@ cls.ResourceDetailView = function(id, name, container_class, html, default_handl
117119
if (!data || data.line == null)
118120
return;
119121

120-
this._root_ele = container.querySelector("." + RESOURCE_DETAIL_CONTAINER_CLASSNAME);
122+
this._root_ele = container.querySelector(this.TEXT_RESOURCE_DETAIL_CONTAINER_SELECTOR);
121123
if (this._root_ele)
122124
{
123125
this.clear_line_highlight(this._root_ele);
@@ -226,9 +228,6 @@ cls.ResourceDetailView.create_ui_widgets = function()
226228
});
227229

228230
var text_search = window.views.resource_detail_view.text_search = new TextSearch();
229-
var TEXT_RESOURCE_DETAIL_CONTAINER_CLASSNAMES = ["markup", "css", "script", "text"].map(function(v) {
230-
return ".resource-detail-" + v + "-container";
231-
});
232231

233232
window.event_handlers.input["resource-text-search"] = function(event, target)
234233
{
@@ -244,13 +243,14 @@ cls.ResourceDetailView.create_ui_widgets = function()
244243
{
245244
if (msg.id === "resource_detail_view")
246245
{
247-
var scroll_container = msg.container.querySelector(TEXT_RESOURCE_DETAIL_CONTAINER_CLASSNAMES);
246+
var view = window.views.resource_detail_view;
247+
var scroll_container = msg.container.querySelector(view.TEXT_RESOURCE_DETAIL_CONTAINER_SELECTOR);
248248

249249
if (scroll_container)
250250
{
251251
text_search.setContainer(scroll_container);
252252
text_search.setFormInput(
253-
views.resource_detail_view.getToolbarControl(msg.container, "resource-text-search")
253+
view.getToolbarControl(msg.container, "resource-text-search")
254254
);
255255
}
256256
}

0 commit comments

Comments
 (0)