Review fixes.

Author: Chris K

src/client/client.js

@@ -552,8 +552,8 @@ ui_framework.layouts.dom_rough_layout =
           return ['dom-side-panel',
                   'dom_attrs',
                   'css-layout',
-                  'dom-search',
-                  'ev-listeners-side-panel'];
+                  'ev-listeners-side-panel',
+                  'dom-search'];
         }
 
         return ['dom-side-panel', 'dom_attrs', 'css-layout', 'dom-search'];

src/ecma-debugger/dominspection/inspectabledomnode.js

@@ -34,37 +34,36 @@ cls.EcmascriptDebugger["6.0"].InspectableDOMNode.PSEUDO_NODE = 0;
 cls.EcmascriptDebugger["6.0"].InspectableDOMNode.prototype = new function()
 {
 
-  const
-  NODE_LIST = 0,
-  ID = 0,
-  TYPE = 1,
-  NAME = 2,
-  DEPTH = 3,
-
-  ATTRS = 5,
-  ATTR_PREFIX = 0,
-  ATTR_KEY = 1,
-  ATTR_VALUE = 2,
-  CHILDREN_LENGTH = 6,
-  PUBLIC_ID = 4,
-  SYSTEM_ID = 5,
-  MATCH_REASON = cls.EcmascriptDebugger["6.0"].InspectableDOMNode.MATCH_REASON,
-  TRAVERSE_SEARCH = "search",
-  TRAVERSAL = 1,
-  SEARCH_PARENT = 2,
-  SEARCH_HIT = 3,
-  PSEUDO_TYPE = 0,
-  PSEUDO_ELEMENT = cls.EcmascriptDebugger["6.0"].InspectableDOMNode.PSEUDO_ELEMENT,
-  PSEUDO_NODE = cls.EcmascriptDebugger["6.0"].InspectableDOMNode.PSEUDO_NODE,
-  BEFORE = 1,
-  AFTER = 2,
-  FIRST_LETTER = 3,
-  FIRST_LINE = 4,
-  BEFORE_ALIKES = [BEFORE, FIRST_LETTER, FIRST_LINE],
-  AFTER_ALIKES = [AFTER],
-  ERROR_MSG = 0,
-  PSEUDO_NAME = {},
-  EVENT_LISTENER_LIST = cls.EcmascriptDebugger["6.0"].InspectableDOMNode.EVENT_LISTENER_LIST;
+  var NODE_LIST = 0;
+  var ID = 0;
+  var TYPE = 1;
+  var NAME = 2;
+  var DEPTH = 3;
+
+  var ATTRS = 5;
+  var ATTR_PREFIX = 0;
+  var ATTR_KEY = 1;
+  var ATTR_VALUE = 2;
+  var CHILDREN_LENGTH = 6;
+  var PUBLIC_ID = 4;
+  var SYSTEM_ID = 5;
+  var MATCH_REASON = cls.EcmascriptDebugger["6.0"].InspectableDOMNode.MATCH_REASON;
+  var TRAVERSE_SEARCH = "search";
+  var TRAVERSAL = 1;
+  var SEARCH_PARENT = 2;
+  var SEARCH_HIT = 3;
+  var PSEUDO_TYPE = 0;
+  var PSEUDO_ELEMENT = cls.EcmascriptDebugger["6.0"].InspectableDOMNode.PSEUDO_ELEMENT;
+  var PSEUDO_NODE = cls.EcmascriptDebugger["6.0"].InspectableDOMNode.PSEUDO_NODE;
+  var BEFORE = 1;
+  var AFTER = 2;
+  var FIRST_LETTER = 3;
+  var FIRST_LINE = 4;
+  var BEFORE_ALIKES = [BEFORE, FIRST_LETTER, FIRST_LINE];
+  var AFTER_ALIKES = [AFTER];
+  var ERROR_MSG = 0;
+  var PSEUDO_NAME = {};
+  var EVENT_LISTENER_LIST = cls.EcmascriptDebugger["6.0"].InspectableDOMNode.EVENT_LISTENER_LIST;
 
   PSEUDO_NAME[BEFORE] = "before";
   PSEUDO_NAME[AFTER] = "after";

src/ecma-debugger/eventlisteners/evlistenersidepanel.js

@@ -16,7 +16,7 @@ cls.EventListenerSidePanelView.create_ui_widgets = function()
     groups:
     [
       {
-        type: "buttons",
+        type: UI.TYPE_BUTTONS,
         items:
         [
           {
@@ -26,7 +26,7 @@ cls.EventListenerSidePanelView.create_ui_widgets = function()
         ]
       },
       {
-        type: "input",
+        type: UI.TYPE_INPUT,
         items:
         [
           {

src/ecma-debugger/eventlisteners/evlistenersview.js

@@ -122,9 +122,9 @@ cls.EventListenersView = function(id, name, container_class)
     this._text_search.set_query_selector(".ev-type");
     this._text_search.add_listener("onbeforesearch", this._onbeforesearch.bind(this));
     evh.input[cls.EventListenersView.TOKEN_FILTER] = this._oninput.bind(this);
-    var glob_handl = ActionBroker.get_instance().get_global_handler();
+    var global_handler = ActionBroker.get_instance().get_global_handler();
     var cb = cls.Helpers.shortcut_search_cb.bind(this._text_search);
-    glob_handl.register_shortcut_listener(cls.EventListenersView.TOKEN_FILTER, cb);
+    global_handler.register_shortcut_listener(cls.EventListenersView.TOKEN_FILTER, cb);
     var contextmenu =
     [
       {

src/ecma-debugger/eventlisteners/evlistenertemplates.js

@@ -38,9 +38,9 @@
     }
     var event_types = search_term
                     ? ev_rt.event_types.filter(function(ev_type)
-                    {
-                      return ev_type.type.contains(search_term);
-                    })
+                      {
+                        return ev_type.type.contains(search_term);
+                      })
                     : ev_rt.event_types;
     ret.push(["ul", event_types.map(this._ev_type, this),
                     "data-rt-id", String(ev_rt.rt_id),

src/ecma-debugger/eventlisteners/selectednodelistenerview.js

@@ -29,7 +29,7 @@ cls.SelectedNodeListenersView = function(id, name, container_class)
     container.clearAndRender(tmpl);
   };
 
-  this._on_elemnet_selected = function(msg)
+  this._on_element_selected = function(msg)
   {
     this._selected_ele = msg;
     this.update();
@@ -39,7 +39,7 @@ cls.SelectedNodeListenersView = function(id, name, container_class)
   {
     this.init(id, name, container_class);
     this._selected_ele = null;
-    window.messages.add_listener("element-selected", this._on_elemnet_selected.bind(this));
+    window.messages.add_listener("element-selected", this._on_element_selected.bind(this));
   };
 
   this._init(id, name, container_class);