Skip to content

Commit ee973a0

Browse files
committed
Fixed DFL-3367: Tooltip of the return value arrows should use the JS tooltip too.
1 parent 76ad5af commit ee973a0

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/ecma-debugger/return_values_view.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ cls.ReturnValuesView = function(id, name, container_class)
8787
this.required_services = ["ecmascript-debugger"];
8888
this._container = null;
8989
this._search_term = "";
90-
90+
this._tooltip = Tooltips.register("return-value-tooltip", false, false);
9191
this._text_search = new TextSearch(1);
9292
this._text_search.add_listener("onbeforesearch", this._onbeforesearch.bind(this));
9393

src/ecma-debugger/templates.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -475,8 +475,10 @@
475475
"↱",
476476
"class", "return-value-arrow return-value-arrow-from",
477477
"handler", "goto-script-line",
478-
"title", ui_strings.S_RETURN_VALUES_FUNCTION_FROM.replace("%s", from_uri)
479-
.replace("%s", retval.positionFrom.lineNumber),
478+
"data-tooltip", "return-value-tooltip",
479+
"data-tooltip-text", ui_strings.S_RETURN_VALUES_FUNCTION_FROM
480+
.replace("%s", from_uri)
481+
.replace("%s", retval.positionFrom.lineNumber),
480482
"data-script-id", String(retval.positionFrom.scriptID),
481483
"data-script-line", String(retval.positionFrom.lineNumber)
482484
],
@@ -489,8 +491,10 @@
489491
"↳",
490492
"class", "return-value-arrow return-value-arrow-to",
491493
"handler", "goto-script-line",
492-
"title", ui_strings.S_RETURN_VALUES_FUNCTION_TO.replace("%s", to_uri)
493-
.replace("%s", retval.positionTo.lineNumber),
494+
"data-tooltip", "return-value-tooltip",
495+
"data-tooltip-text", ui_strings.S_RETURN_VALUES_FUNCTION_TO
496+
.replace("%s", to_uri)
497+
.replace("%s", retval.positionTo.lineNumber),
494498
"data-script-id", String(retval.positionTo.scriptID),
495499
"data-script-line", String(retval.positionTo.lineNumber)
496500
],

0 commit comments

Comments
 (0)