Fix for DFL-3310, Syntax error when auto-completing after "in".

Author: Chris K

src/repl/propertyfinder.js

@@ -27,18 +27,19 @@ window.cls.PropertyFinder = function(rt_id) {
   this._parser = window.simple_js_parser || new window.cls.SimpleJSParser();
 
   const PUNCTUATOR = cls.SimpleJSParser.PUNCTUATOR;
+  const IDENTIFIER = cls.SimpleJSParser.IDENTIFIER;
   const TYPE = 0;
   const VALUE = 1;
 
-  this._get_last_punctuator = function(tokens, punctuator)
+  this._get_last_token = function(tokens, token_type, token_value)
   {
     if (tokens)
     {
       for (var i = tokens.length - 1, token; token = tokens[i]; i--)
       {
-        if (token[TYPE] == PUNCTUATOR && token[VALUE] == punctuator)
+        if (token[TYPE] == token_type && token[VALUE] == token_value)
         {
-          for (var j = 0, index = 0; j < i; j++)
+          for (var j = 0, index = 0; j <= i; j++)
             index += tokens[j][VALUE].length;
           return index;
         }
@@ -66,18 +67,19 @@ window.cls.PropertyFinder = function(rt_id) {
       tokens.push([token_type, token]);
     });
 
-    var last_bracket = this._get_last_punctuator(tokens, '[');
-    var last_brace = this._get_last_punctuator(tokens, '(');
+    var last_bracket = this._get_last_token(tokens, PUNCTUATOR, '[');
+    var last_brace = this._get_last_token(tokens, PUNCTUATOR, '(');
 
-    last_brace = this._get_last_punctuator(tokens, ')') <= last_brace 
+    last_brace = this._get_last_token(tokens, PUNCTUATOR, ')') <= last_brace
                ? last_brace
                : -1;
-    last_bracket = this._get_last_punctuator(tokens, ']') <= last_bracket 
+    last_bracket = this._get_last_token(tokens, PUNCTUATOR, ']') <= last_bracket
                  ? last_bracket
                  : -1;
     input = input.slice(Math.max(last_brace,
                                  last_bracket,
-                                 this._get_last_punctuator(tokens, '=')) + 1);
+                                 this._get_last_token(tokens, PUNCTUATOR, '='),
+                                 this._get_last_token(tokens, IDENTIFIER, 'in')));
     input = input.replace(/^\s+/, '');
 
     var last_dot = input.lastIndexOf('.');