Removed unused properties; DFL-3614: 'Name' and 'Value' labels in network details should not have 'not-content' class

Author: Daniel Herzog

src/network/network_details_templates.js

@@ -201,14 +201,14 @@ templates._request_headers = function(req, do_raw)
       return this._pre(this.headers_tonkenized(header_tokens, false));
     }
     return ["span", ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL,
-            "class", templates.UI_CLASSNAMES];
+            "class", templates.UI_CLASSNAME];
   }
 
   var ret = [];
   if (!req.request_headers)
   {
     ret.push(["span", ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL,
-              "class", templates.UI_CLASSNAMES]);
+              "class", templates.UI_CLASSNAME]);
   }
   else
   {
@@ -286,7 +286,7 @@ templates._response_headers = function(resp, do_raw)
       return this._pre(this.headers_tonkenized(header_tokens, true));
     }
     return ["span", ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL,
-            "class", templates.UI_CLASSNAMES];
+            "class", templates.UI_CLASSNAME];
   }
 
   var ret = resp.response_headers && resp.response_headers.map(this._headers_pseudo_raw);
@@ -302,7 +302,7 @@ templates._response_headers = function(resp, do_raw)
   if (!ret)
   {
     ret = ["span", ui_strings.S_NETWORK_REQUEST_NO_HEADERS_LABEL,
-           "class", templates.UI_CLASSNAMES];
+           "class", templates.UI_CLASSNAME];
   }
   return templates._pre(ret);
 };
@@ -364,7 +364,7 @@ templates._request_body = function(req, do_raw)
         ret.push(part.content.stringData);
       else
         ret.push(["span", ui_strings.S_NETWORK_N_BYTE_BODY.replace("%s", part.contentLength),
-                               "class", templates.UI_CLASSNAMES]);
+                               "class", templates.UI_CLASSNAME]);
 
       if (use_raw_boundary && part === req.request_body.partList.last)
         raw_boundary += "--";
@@ -388,8 +388,8 @@ templates._request_body = function(req, do_raw)
       var rows = [];
       rows.push([
         "tr",
-          ["th", ["span", ui_strings.S_LABEL_NETWORK_POST_DATA_NAME, "class", templates.UI_CLASSNAMES]],
-          ["th", ["span", ui_strings.S_LABEL_NETWORK_POST_DATA_VALUE, "class", templates.UI_CLASSNAMES]]
+          ["th", ["span", ui_strings.S_LABEL_NETWORK_POST_DATA_NAME, "class", templates.UI_CLASSNAME]],
+          ["th", ["span", ui_strings.S_LABEL_NETWORK_POST_DATA_VALUE, "class", templates.UI_CLASSNAME]]
         ]
       );
       rows.extend(parts.map(this.param_cells));
@@ -411,12 +411,12 @@ templates._request_body = function(req, do_raw)
         if (req.request_body.mimeType)
         {
           ret = ["span", ui_strings.S_NETWORK_CANT_DISPLAY_TYPE.replace("%s", req.request_body.mimeType),
-                 "class", templates.UI_CLASSNAMES];
+                 "class", templates.UI_CLASSNAME];
         }
         else
         {
           ret = ["span", ui_strings.S_NETWORK_UNKNOWN_MIME_TYPE,
-                 "class", templates.UI_CLASSNAMES];
+                 "class", templates.UI_CLASSNAME];
         }
       }
     }
@@ -470,7 +470,7 @@ templates._response_body = function(resp, do_raw, is_last_response)
       {
         ret.push(
           ["span", ui_strings.S_NETWORK_REQUEST_DETAIL_UNDISPLAYABLE_BODY_LABEL.replace("%s", resp.logger_entry_mime),
-           "class", templates.UI_CLASSNAMES]
+           "class", templates.UI_CLASSNAME]
         );
       }
     }

src/network/network_service.js

@@ -990,8 +990,6 @@ cls.NetworkLoggerRequest = function(entry)
   this.request_body = null;
   this.boundary = "";
   this.was_responded_to = false;
-  // Set from template code, when first needed:
-  this.header_tokens = null;
 };
 
 cls.NetworkLoggerRequestPrototype = function()
@@ -1044,7 +1042,6 @@ cls.NetworkLoggerResponse = function(entry)
   this.response_headers = null;
   this.response_headers_raw = null;
   this.responsebody = null;
-  this.header_tokens = null; // This is set from template code, when it's first needed
   this.is_response = true; // Simpler for recognizing than dealing with comparing the constructor
   this.saw_responsefinished = false;
 

src/network/network_style.css

@@ -356,14 +356,6 @@
   white-space: nowrap;
 }
 
-.network-detail-overlay .not-content
-{
-  padding: 0;
-  color: #808080;
-  cursor: default;
-  font-weight: normal;
-}
-
 .network-detail-overlay th:first-child,
 .network-detail-overlay td:first-child
 {

src/network/network_templates.js

@@ -13,7 +13,7 @@ var GRAPH_PADDING = (TIMELINE_MARKER_WIDTH / 2) + MIN_BAR_WIDTH + SECTIONS_HITAR
 var UNREFERENCED = templates.UNREFERENCED = "unreferenced";
 var ERROR_RESPONSE = templates.ERROR_RESPONSE = "error_response";
 var NOT_REQUESTED = templates.NOT_REQUESTED = "not_requested";
-var UI_CLASSNAMES = templates.UI_CLASSNAMES = "not-content ui-font";
+var UI_CLASSNAME = templates.UI_CLASSNAME = "ui-font";
 
 templates.options_main = function(nocaching, tracking, headers, overrides)
 {